Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker file for cellranger #8

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Conversation

TomKellyGenetics
Copy link
Member

Cellranger requires a specific implementation of tSNE. See PR #5 and #7 for related changes.

Many thanks to contributing to nf-core/demultiplex!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/demultiplex branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/demultiplex/tree/master/.github/CONTRIBUTING.md

cellranger requires a specific implementation of tSNE
@TomKellyGenetics
Copy link
Member Author

TomKellyGenetics commented Mar 13, 2020

I consider this repository stable now. It runs the test job locally. All that's left is configuring GitHub Integrations (autobuild and autotest). https://github.com/TomKellyGenetics/cellranger_clean/
This applies to these as well: PR #5 PR #7

@drpatelh
Copy link
Member

Thanks for voluntarily coming in to suggest these changes @TomKellyGenetics 😎 . We should get an automated build on Dockerhub once this PR is merged. Once the container has build successfully I will most likely switch off the autobuilds due to these crazy dependency issues. I think it will be fine to have a static version of the container for now as long as its working!

@drpatelh drpatelh merged commit 6537457 into nf-core:dev Mar 13, 2020
@drpatelh
Copy link
Member

Build is still failing because Dockerhub cant find requirements.txt:

---> b52b89f29318
Step 12/31 : COPY requirements.txt /opt/requirements.txt
COPY failed: stat /var/lib/docker/tmp/docker-builder130847410/requirements.txt: no such file or directory

@drpatelh
Copy link
Member

I realised its probably much easier to just get the Docker image you have kindly provided on Dockerhub @TomKellyGenetics . Hope thats ok?
d16ce50

@TomKellyGenetics
Copy link
Member Author

I think this is because it requires a "requirements.txt" in the working directory when docker build is running. For example this one https://github.com/TomKellyGenetics/cellranger_clean/blob/master/requirements.txt

Build is still failing because Dockerhub cant find requirements.txt:

---> b52b89f29318
Step 12/31 : COPY requirements.txt /opt/requirements.txt
COPY failed: stat /var/lib/docker/tmp/docker-builder130847410/requirements.txt: no such file or directory

I'm okay with this and intend to leave it stable for my purposes (a lot of dependencies are current versions or specific commits to avoid updates breaking it). Credit should go to the original developers of cellranger for releasing it open-source and to @mckinsel for building a docker image of an older version: https://github.com/mckinsel/cellranger_clean

I realised its probably much easier to just get the Docker image you have kindly provided on Dockerhub @TomKellyGenetics . Hope thats ok?
d16ce50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants