-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nf-validation on samplesheet #88
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I give my ok here before all tests succeeded, please wait until those are all fine.
I spotted two warnings in the tests:
that can be easily removed by importing those processes under different names. Maybe for another PR. |
Great!!. Thanks for the review. Concerning the warnings, I've been unable to replicate them when running I will test it further and do another PR. |
PR checklist
nf-core lint
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).PR description
Added nf-validation on sample sheet (#87). It enables the parsing of input sample sheets in various formats, including TSV, CSV, and YAML files.
Now, INPUT_CHECK() subworfklow is no longer requiered.