Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide cursor in print output #5063

Merged
merged 3 commits into from
Nov 30, 2023
Merged

fix: Hide cursor in print output #5063

merged 3 commits into from
Nov 30, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 30, 2023

Follow up to #5054 to make tests more stable by hiding the cursor that may be more or less transparent depending on the activity state.

Also it is not much useful in print view.

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Nov 30, 2023
@mejo-
Copy link
Member

mejo- commented Nov 30, 2023

Thanks for the follow-up. Let me push two more commits in the hope they help:

  • Set caret-color to transparent before doing the snapshot
  • One more time update the screenshots

@mejo-
Copy link
Member

mejo- commented Nov 30, 2023

But looking at the screenshot diffs it rather seems like the whole rendering is not pixel-perfect and moves a few pixels up/down left/right between runs 🤔

@mejo- mejo- merged commit 72f1ff7 into main Nov 30, 2023
37 checks passed
@mejo- mejo- deleted the bugfix/noid/hide-cursor-print branch November 30, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants