Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): Fix print view in viewer and single-file share #5054

Merged
merged 9 commits into from
Nov 29, 2023
Merged

fix(css): Fix print view in viewer and single-file share #5054

merged 9 commits into from
Nov 29, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Nov 29, 2023

📝 Summary

Also adds screenshot comparison tests for print view in viewer and single-file share.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@mejo- mejo- requested review from susnux and juliusknorr November 29, 2023 15:58
mejo- added 2 commits November 29, 2023 17:08
@mejo-
test(cypress): Add test to visually compare print view
a73f1f3 
Compare print view of long document visually using
`cypress-visual-regression` to detect regressions in print view in the
future.

Signed-off-by: Jonas <[email protected]>
@mejo-
fix(css): Fix print view in single-file shares
9af378d 
Signed-off-by: Jonas <[email protected]>
@mejo- mejo- force-pushed the fix/print_css branch 4 times, most recently from fda43c5 to 9b666c9 Compare November 29, 2023 18:08
@mejo-
Copy link
Member Author

mejo- commented Nov 29, 2023

/compile

@mejo-
Copy link
Member Author

mejo- commented Nov 29, 2023

The snapshot comparison will only succeed after the JS assets got updated. So let's try to compile+push them into the PR.

juliusknorr
juliusknorr approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, especially having those tests 👍

@juliusknorr
Copy link
Member

Nah, looks like the font stack used by your local snapshots is different from CI 🙈

mejo- added 2 commits November 29, 2023 20:46
@mejo-
test(cypress): Add test to visually compare print view in single-file…
624651e 
… share

Visually compare print view of long document in single-file share.

Signed-off-by: Jonas <[email protected]>
@mejo-
test(ci): Upload cypress snapshots on failure
5c7d391 
Signed-off-by: Jonas <[email protected]>
@mejo-
Copy link
Member Author

mejo- commented Nov 29, 2023

/compile

@nextcloud-command
chore(assets): Recompile assets
f4b2c72 
Signed-off-by: nextcloud-command <[email protected]>
@mejo-
Copy link
Member Author

mejo- commented Nov 29, 2023

Nah, looks like the font stack used by your local snapshots is different from CI 🙈

Yeah, the joy of visual comparison tests 🤪 I updated it now with the snapshots created by CI.

@mejo- mejo- merged commit 7e97a61 into main Nov 29, 2023
44 of 47 checks passed
@mejo- mejo- deleted the fix/print_css branch November 29, 2023 20:10
@mejo-
Copy link
Member Author

mejo- commented Nov 29, 2023

/backport to stable28

@mejo-
Copy link
Member Author

mejo- commented Nov 29, 2023

/backport 90ce11e,aff3a1add26cf0edc12f2c624c4a109edf320a46,280948b35e63b46cbf446657c73492343bf4f79d,035f5cc900528277b3ead8e8640e885cb80af949,a73f1f339f78aed55c7f2efc28e384ff3e39a641,9af378da3ba7675db4b3f2f9244c8b4e1d923bd0,624651e86f7f681f51fa8e35931f4ab9a6f33a87,5c7d3918dbc790273aa6a9dacf2c36f701b7d7ea to stable28

@juliusknorr juliusknorr mentioned this pull request Nov 30, 2023
Merged
@mejo- mejo- mentioned this pull request Nov 30, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@joshtrichards joshtrichards mentioned this pull request Aug 9, 2024
Open
@suther
Copy link

suther commented Dec 4, 2024

Is this issue at least solved or still in progress.
Currently it look like this at my PC if I try to print any note in nextcloude notes:

image

Can I give helping hand in any way to solve this.

BTW: On Android there are no print-functionality at all for the notes. A huge downside in my opinion for a note -app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Printing (from browser) is broken (again)
4 participants
@mejo- @juliusknorr @suther @nextcloud-command