Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List fixes #4735

Merged
merged 3 commits into from
Sep 5, 2023
Merged

List fixes #4735

merged 3 commits into from
Sep 5, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 29, 2023

@juliusknorr juliusknorr changed the title bugfix/lists List fixes Aug 29, 2023
@juliusknorr juliusknorr marked this pull request as ready for review August 29, 2023 17:27
@cypress
Copy link

cypress bot commented Aug 29, 2023

3 failed and 1 flaky tests on run #12031 ↗︎

3 141 18 0 Flakiness 1

Details:

List fixes
Project: Text Commit: fafb9fc996
Status: Failed Duration: 12:33 💡
Started: Sep 5, 2023 2:35 PM Ended: Sep 5, 2023 2:48 PM
Failed  cypress/e2e/attachments.spec.js • 3 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > test if attachment folder is moved with the markdown file Output Screenshots
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots
Flakiness  cypress/e2e/api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Aug 29, 2023
@juliusknorr juliusknorr force-pushed the bugfix/lists branch 2 times, most recently from a19f1ed to 4587795 Compare September 1, 2023 10:01
@juliusknorr
Copy link
Member Author

Test added for the tab key behaviour of lists in viewer

@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Sep 1, 2023
@juliusknorr juliusknorr mentioned this pull request Sep 5, 2023
5 tasks
@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr
Copy link
Member Author

/backport to stable26

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me 👌 Bonus points for the Cypress test ❤️

@juliusknorr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit ff8c2d0 into main Sep 5, 2023
29 of 31 checks passed
@juliusknorr juliusknorr deleted the bugfix/lists branch September 5, 2023 16:43
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@max-nextcloud
Copy link
Collaborator

/backport 741621a,8e28145 to stable27

@max-nextcloud
Copy link
Collaborator

/backport 741621a,8e28145 to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
4 participants