Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC25: Tab key shortcut broken - NO possibility increase list intentional level anymore #3493

Closed
Pilzinsel64 opened this issue Nov 28, 2022 · 6 comments · Fixed by #4735
Closed
Labels
bug Something isn't working high regression

Comments

@Pilzinsel64
Copy link

Pilzinsel64 commented Nov 28, 2022

Describe the bug

  • Since Nextcloud 25 it is not possible anymore to increase the intentional level of a list entry. Traditionally it gets done via the TAB key but since NC25 this TAB key points to the close button.
  • There is no other option to increase the list intentional level
  • The only workaround: Download the file, enter the TAB in the raw text file, upload the file again and continue work. This can be annoying when doing slightly bigger lists.

(Not sure if this bug should be addresses to the viewer app instead, as some people mentoined the TAB key still works in Collective Apps that uses text.)

To Reproduce
Steps to reproduce the behavior:

  1. Open a (new) text file
  2. Start a new list and write the first entry
  3. Press enter to start the second point
  4. Now press TAB on keyboard to increase the list intentional level because we want to add a sub-entry to the collection

Expected behavior
The intentional level of the second entry should get increased by one, like this (As of Nextcloud 24.0.7):
grafik

Screenshots
Instead the close button get focused.
grafik

Client details:

  • OS: Windows 11
  • Browser: Firefox
  • Version: 107.0
  • Device: Desktop
Server details

Text app version: 3.6.0

Operating system: Ubuntu Server 22.04.1 LTS

Web server: Apache

Database: MySql (MariaDB)

PHP version: 8.0

Nextcloud version: 25.0.1 & 25.0.2 RC1

Logs

Nextcloud log (data/nextcloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...
@Pilzinsel64 Pilzinsel64 added the bug Something isn't working label Nov 28, 2022
@Pilzinsel64
Copy link
Author

Pilzinsel64 commented Nov 28, 2022

Another important notice:

  • This happens only if there is NO headline in the document. It doesn't matter where that headline is, as soon as at least one headline is there, the TAB key works again.

@rba7sp
Copy link

rba7sp commented Jan 30, 2023

I'm having the same issue and can confirm the workaround.

@BernhardBaumrock
Copy link

@Pilzinsel64 you are a genius, thank you!

@mejo-
Copy link
Member

mejo- commented Jun 7, 2023

This bug only occurs when Text is loaded in the Viewer. In Collectives or a single file public share, it doesn't occur.

And even if loaded in Viewer, the tab key to increase list indention works if any of the following node types exist in the document:

  • heading
  • link (with link preview widget)
  • table

In a document with just a heading and a list, key tab indention stops working when commenting out addNodeView(). And indeed, all three node extensions result in a VueNodeView being loaded. But on the other hand, many other node extensions (like mentions, image, callout) don't result in tab indention working. So for now I'm a bit clueless 🤔

@mejo-
Copy link
Member

mejo- commented Jun 7, 2023

Another noticable difference: when logging the keydown and keyup events in Firefox Debugger, the parent element is div.ProseMirror in documents where tab indention doesn't work, but div.ProseMirror.ProseMirror-focused in documents where it works.

@mejo-
Copy link
Member

mejo- commented Jul 3, 2023

This is still an issue and needs further debugging.

@github-project-automation github-project-automation bot moved this from 🧭 Planning evaluation (don't pick) to ☑️ Done in 📝 Office team Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high regression
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants