Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky Cypress tests #1204

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix: flaky Cypress tests #1204

merged 2 commits into from
Jul 17, 2024

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Jul 15, 2024

The styling of some Nextcloud Vue components, which is causing some Cypress tests to fail. This fixes those failing tests, as well as uses selectors that are more robust to styling changes

@enjeck enjeck force-pushed the fix-cypress-nav branch from 5b9d9c4 to a044db1 Compare July 15, 2024 18:01
@enjeck enjeck changed the title fix: use less brittle Cypress selectors for navigation fix: use less brittle nav selectors for Cypress tests Jul 15, 2024
@enjeck enjeck force-pushed the fix-cypress-nav branch 2 times, most recently from b1a209c to 80ca2e9 Compare July 16, 2024 06:04
@enjeck enjeck changed the base branch from main to automated/update-workflows/default July 17, 2024 05:34
@enjeck enjeck changed the base branch from automated/update-workflows/default to main July 17, 2024 05:35
@enjeck enjeck force-pushed the fix-cypress-nav branch from 80ca2e9 to 5c43239 Compare July 17, 2024 11:46
@enjeck enjeck changed the title fix: use less brittle nav selectors for Cypress tests fix: flaky Cypress tests Jul 17, 2024
@enjeck enjeck requested review from juliusknorr and elzody July 17, 2024 12:44
@enjeck enjeck self-assigned this Jul 17, 2024
@enjeck enjeck added the 3. to review Waiting for reviews label Jul 17, 2024
@juliusknorr juliusknorr merged commit c79bf0b into main Jul 17, 2024
46 checks passed
@juliusknorr juliusknorr deleted the fix-cypress-nav branch July 17, 2024 15:02
@enjeck
Copy link
Contributor Author

enjeck commented Jul 23, 2024

/backport to stable0.7

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jul 23, 2024
@backportbot backportbot bot mentioned this pull request Jul 23, 2024
2 tasks
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants