fix: use less brittle Cypress selectors for navigation

Signed-off-by: Cleopatra Enjeck M <[email protected]>
nextcloud · Jul 15, 2024 · a044db1 · a044db1
1 parent 6c28efa
commit a044db1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/cypress/support/commands.js b/cypress/support/commands.js
@@ -32,8 +32,9 @@ Cypress.env('baseUrl', url)
 addCommands()
 
 Cypress.Commands.add('createTable', (title) => {
-	cy.contains('.app-menu-entry--label', 'Tables').click()
-	cy.get('button[aria-label="Create new table"]').click()
+	cy.get('[data-cy="navigationCreateTableIcon"]').click({ force: true })
+	cy.wait(1000)
+	cy.get('[data-cy="createTableModal"]').should('be.visible')
 	cy.get('.tile').contains('Custom table').click({ force: true })
 	cy.get('.modal__content input[type="text"]').clear().type(title)
 	cy.contains('button', 'Create table').click()
@@ -92,11 +93,11 @@ Cypress.Commands.add('sortTableColumn', (columnTitle, mode = 'ASC') => {
 })
 
 Cypress.Commands.add('loadTable', (name) => {
-	cy.get('.app-navigation-entry a[title="' + name + '"]').click({ force: true })
+	cy.get('[data-cy="navigationTableItem"] a[title="' + name + '"]').click({ force: true })
 })
 
 Cypress.Commands.add('loadView', (name) => {
-	cy.get('.app-navigation-entry a[title="' + name + '"]').click({ force: true })
+	cy.get('[data-cy="navigationViewItem"] a[title="' + name + '"]').click({ force: true })
 })
 
 Cypress.Commands.add('unifiedSearch', (term) => {

diff --git a/src/modules/navigation/sections/Navigation.vue b/src/modules/navigation/sections/Navigation.vue
@@ -25,7 +25,7 @@
 				<NcAppNavigationCaption :name="t('tables', 'Tables')">
 					<template #actions>
 						<NcActionButton :aria-label="t('tables', 'Create table')" icon="icon-add"
-							@click.prevent="createTable" />
+							data-cy="navigationCreateTableIcon" @click.prevent="createTable" />
 					</template>
 				</NcAppNavigationCaption>