Fix postgres integration tests #7517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
2. developing
feature: chat 💬
nickvergessen
changed the title
nickvergessen
commented
Jul 5, 2022
nickvergessen
commented
Jul 5, 2022
| @@ -222,7 +222,7 @@ public function createCommentObject(array $row): ?IComment { | |||
| 'creation_timestamp' => $row['comment_creation_timestamp'], | |||
| 'latest_child_timestamp' => $row['comment_latest_child_timestamp'], | |||
| 'reactions' => $row['comment_reactions'], | |||
| 'expire_date' => $row['expire_date'], | |||
| 'expire_date' => $row['comment_expire_date'], | |||
There was a problem hiding this comment.
{"Exception":"Error","Message":"Undefined array key \"expire_date\" at \/drone\/server\/apps\/spreed\/lib\/Manager.php#225","Code":0,"Trace":[{"file":"\/drone\/server\/apps\/spreed\/lib\/Manager.php","line":225,"function":"onError","class":"OC\\Log\\ErrorHandler","type":"::"},{"file":"\/drone\/server\/apps\/spreed\/lib\/Manager.php","line":150,"function":"createCommentObject","class":"OCA\\Talk\\Manager","type":"->"},{"file":"\/drone\/server\/apps\/spreed\/lib\/Manager.php","line":343,"function":"createRoomObject","class":"OCA\\Talk\\Manager","type":"->"},{"file":"\/drone\/server\/apps\/spreed\/lib\/Manager.php","line":300,"function":"getRoomsForActor","class":"OCA\\Talk\\Manager","type":"->"},{"file":"\/drone\/server\/apps\/spreed\/lib\/Controller\/RoomController.php","line":194,"function":"getRoomsForUser","class":"OCA\\Talk\\Manager","type":"->"},{"file":"\/drone\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":225,"function":"getRooms","class":"OCA\\Talk\\Controller\\RoomController","type":"->"},{"file":"\/drone\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":133,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/server\/lib\/private\/AppFramework\/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/server\/lib\/private\/Route\/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/drone\/server\/ocs\/v1.php","line":62,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/drone\/server\/ocs\/v2.php","line":23,"args":["\/drone\/server\/ocs\/v1.php"],"function":"require_once"}],"File":"\/drone\/server\/lib\/private\/Log\/ErrorHandler.php","Line":92,"CustomMessage":"--"}
nickvergessen
commented
Jul 5, 2022
| $result = $query->executeQuery(); | ||
| return $result->fetchOne(); | ||
| $roomId = (int) $result->fetchOne(); |
There was a problem hiding this comment.
{"Exception":"Exception","Message":"OCA\\SpreedCheats\\Controller\\ApiController::getRoomIdByToken(): Return value must be of type ?string, int returned in file '\/drone\/server\/apps\/spreedcheats\/lib\/Controller\/ApiController.php' line 141","Code":0,"Trace":[{"file":"\/drone\/server\/lib\/private\/AppFramework\/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/server\/lib\/private\/Route\/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/drone\/server\/ocs\/v1.php","line":62,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/drone\/server\/ocs\/v2.php","line":23,"args":["\/drone\/server\/ocs\/v1.php"],"function":"require_once"}],"File":"\/drone\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","Line":165,"Previous":{"Exception":"TypeError","Message":"OCA\\SpreedCheats\\Controller\\ApiController::getRoomIdByToken(): Return value must be of type ?string, int returned","Code":0,"Trace":[{"file":"\/drone\/server\/apps\/spreedcheats\/lib\/Controller\/ApiController.php","line":114,"function":"getRoomIdByToken","class":"OCA\\SpreedCheats\\Controller\\ApiController","type":"->"},{"file":"\/drone\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":225,"function":"getMessageExpirationJob","class":"OCA\\SpreedCheats\\Controller\\ApiController","type":"->"},{"file":"\/drone\/server\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":133,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/server\/lib\/private\/AppFramework\/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/server\/lib\/private\/Route\/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/drone\/server\/ocs\/v1.php","line":62,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/drone\/server\/ocs\/v2.php","line":23,"args":["\/drone\/server\/ocs\/v1.php"],"function":"require_once"}],"File":"\/drone\/server\/apps\/spreedcheats\/lib\/Controller\/ApiController.php","Line":141},"CustomMessage":"--"}
|
Tests are finally green, please review so I can revert the postgres drone file change and merge the PR tomorrow morning after CI is done. |
danxuliu
approved these changes
Jul 6, 2022
That is what reverting is to me unless it was merged into master/main :-P |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/fix-postgres-integration-tests
branch
from
b6a0c67 to
6452acf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.