-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning when FPM is used with MPM_PREFORK #7516
Conversation
Signed-off-by: Joas Schilling <[email protected]>
17a5122
to
9e3ee51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny fact, apachectl -M
can fail when executed through the web server even if it works when executed as root if any of the modules needs to read a file accessible only by root (for example, the SSH certificates). Of course that is a corner case, but I wonder if that could fail too in more common scenarios.
Independently of that, what about SystemKeeper's suggestion to rely on the .htaccess file? That would require mod_env to be set, but that is needed anyway for the default setup of Nextcloud (SetEnv
is used in the main .htaccess file and if the variable is not found an error is shown in the setup checks).
And for reference, I was able to reproduce the performance problem when using FPM and mpm_prefork if several clients were long polling.
The problem is this would need to go into the root |
Mmm, right, htaccess files do not seem to have effect for PHP files in subdirectories if they are loaded by other PHP files rather than directly by the web server :-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of calling apachectl
, but apparently that approach is the only one that (except on corner cases) works 🤷, so 👍
But, what happens if NGINX is used instead?
It bails out with being a "valid configuration" |
Failing test is fixed by #7517 So merging |
Test still fails when running Nextcloud on a semi popular web control panel I'm afraid, when I check on a standard Apache with PHP 8.2 in php-fpm mode:
Though I'm still getting a "It seems that the PHP and Apache configuration is not compatible. Please note that PHP can only be used with the MPM_PREFORK module and PHP-FPM can only be used with the MPM_EVENT module." warning. |
Fix #7499