Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Split reporting of candidates by protocol" #5236

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Revert "Split reporting of candidates by protocol" #5236

merged 1 commit into from
Feb 22, 2021

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 22, 2021 •
edited
Loading

Reverting #5103

@nickvergessen nickvergessen added 3. to review bug regression feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients labels Feb 22, 2021
@nickvergessen nickvergessen added this to the 💖 Next Major (22) milestone Feb 22, 2021
danxuliu
danxuliu approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@nickvergessen nickvergessen merged commit ff2e7d5 into master Feb 22, 2021
@nickvergessen nickvergessen deleted the revert-5103-bugfix/noid/correctly-report-errors-of-single-protocols branch February 22, 2021 08:55
@danxuliu
Copy link
Member

The fix was backported to stable21, but it is currently missing in stable21.1.

@danxuliu
Copy link
Member

/backport to stable21.1

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients regression
Projects
None yet
Milestone
v12.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @danxuliu