Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split reporting of candidates by protocol #5103

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Split reporting of candidates by protocol #5103

merged 1 commit into from
Feb 9, 2021

Conversation

nickvergessen
Copy link
Member

Before

  1. Have a turn that only has working UDP (no TCP)
  2. Configure it in admin settings for both
  3. Use the test function

Expected

Reported error for TCP

Actually

Reported as working

@nickvergessen nickvergessen added 3. to review bug feature: settings ⚙️ Settings and config related issues labels Feb 9, 2021
@nickvergessen nickvergessen added this to the 💖 Next Major (22) milestone Feb 9, 2021
@nickvergessen
Copy link
Member Author

/backport to stable21

PVince81
PVince81 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@PVince81 PVince81 merged commit 066087b into master Feb 9, 2021
@PVince81 PVince81 deleted the bugfix/noid/correctly-report-errors-of-single-protocols branch February 9, 2021 10:55
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 9, 2021
Merged
@nickvergessen nickvergessen mentioned this pull request Feb 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: settings ⚙️ Settings and config related issues
Projects
None yet
Milestone
v12.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @PVince81