Reset attachment folder when it cannot be created #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
bug
feature: upload & shares & voice 📤🎙️
|
cc @Dubidubiduu |
|
/backport to stable19 |
szaimen
approved these changes
Jun 10, 2020
Dubidubiduu
reviewed
Jun 10, 2020
|
Yeah because you dont have any quota you can of course not upload files |
nickvergessen
deleted the
bugfix/3590/change-attachment-folder-when-it-cannot-be-created
branch
|
@Dubidubiduu this will be further handled in #3430 |
szaimen
reviewed
Jun 10, 2020
| @@ -96,9 +92,16 @@ protected function publishInitialStateForUser(IUser $user, IRootFolder $rootFold | |||
| $userFolder->newFolder($attachmentFolder); | |||
| } | |||
| } catch (NotPermittedException $e) { | |||
| $attachmentFolder = '/'; | |||
| $this->serverConfig->setUserValue($user->getUID(), 'spreed', 'attachment_folder', '/'); | |||
There was a problem hiding this comment.
@nickvergessen is there a way to do this via occ?
I would think about some command like:
occ config:system:set spreed attachment_folder --value="/" --user="exampleuser"
or
occ config:app:set spreed attachment_folder --value="/" --user="exampleuser"
There was a problem hiding this comment.
I know, it is not needed here, since it will work now, but I would like to use it via cli to set it automatically to another value for my users...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3590