Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change the upload directory if the root folder is read only #3590

Closed
szaimen opened this issue May 15, 2020 · 7 comments · Fixed by #3794
Closed

Cannot change the upload directory if the root folder is read only #3590

szaimen opened this issue May 15, 2020 · 7 comments · Fixed by #3794

Comments

@szaimen
Copy link
Contributor

szaimen commented May 15, 2020

Steps to reproduce

  1. create a root folder that is read only and an additional normal mount that is writable (and not named Talk) with the external storage app
  2. try to change the upload folder in the talk app by clicking into the field
  3. the folder picker opens but doesn't end loading: it seems to expect that the default talk folder was created but it wasn't since the root directory is read only.

Expected behaviour

the upload picker should load and let me choosing the upload folder without having to make the root directory writeable or creating a talk folder inside the root directory before.

Actual behaviour

see point 3 above

Browser

Microphone available: yes/no
yes
Camera available: yes/no
yes
Operating system: Windows/Ubuntu/...
Windows 10
Browser name: Firefox/Chrome/...
Chromium based browser
Browser version: 50.1/55/...
81

Talk app

Talk app version: (see apps admin page: /index.php/settings/apps)
9.0.0beta1
Custom TURN server configured: yes/no (see additional admin settings: /index.php/settings/admin/additional)
no
Custom STUN server configured: yes/no (see additional admin settings: /index.php/settings/admin/additional)
no

Server configuration

Operating system: Ubuntu/RedHat/...
Ubuntu 20.04
Web server: Apache/Nginx
Apache2
Database: MySQL/Maria/SQLite/PostgreSQL
PostgreSQL
PHP version:
7.4
Nextcloud Version: (see admin page)
19.0.0RC2

@szaimen szaimen changed the title Cannot change the upload directory if the root folder is writable Cannot change the upload directory if the root folder is read only May 15, 2020
@szaimen
Copy link
Contributor Author

szaimen commented May 15, 2020

BTW: of course the file upload doesn't work either as long as the folder isn't existing and cannot get created...

@szaimen
Copy link
Contributor Author

szaimen commented May 18, 2020

@nickvergessen I think the problem here is that you are trying to open the folder picker in the default directory /Talk which breaks because it cannot get created on my setup.

The bug could probably get solved by opening the folder picker in the root directory if the default /Talk directory couldn't get created.

Does that make sense?

@nickvergessen
Copy link
Member

Sounds good. I was not aware a read only root is a thing. Will check with others

@szaimen
Copy link
Contributor Author

szaimen commented May 18, 2020

I think this was the PR which made it possible to mount an external storage folder as root directory and thus allows us to make it read only:
nextcloud/server#3438

@Dubidubiduu
Copy link

Confirm on nc 19.0.0 and Talk 9.0.1.

My config:
Only groupfolders, home is not writable by users, users have 0kb space. Will talk file share work again with these settings?

@szaimen
Copy link
Contributor Author

szaimen commented Jun 10, 2020

@Dubidubiduu As a workaround you could mount an external storage folder or groupfolder named Talk read only to all users. Then should changing the upload directory work again.

@szaimen
Copy link
Contributor Author

szaimen commented Jun 10, 2020

Of course this is not optimal especially if you have many users because every user has to change the upload directory by themselves to a directory where they can write before uploading works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants