Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(federation): Support mentioning federated users #11664

Merged
merged 4 commits into from
Feb 28, 2024
Merged

feat(federation): Support mentioning federated users #11664

merged 4 commits into from
Feb 28, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 27, 2024 •
edited
Loading

🛠️ API Checklist

🚧 Tasks

  • Fix mentioning federated users
  • Fix parent message actor information
  • Convert (federated) users in message parameters

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Feb 27, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Feb 27, 2024
@nickvergessen nickvergessen self-assigned this Feb 27, 2024
@nickvergessen nickvergessen force-pushed the feat/noid/mention-federated-users branch 3 times, most recently from 4ff633a to 07ecc5d Compare February 28, 2024 08:07
@nickvergessen nickvergessen force-pushed the feat/noid/mention-federated-users branch 2 times, most recently from 05c37e8 to 677f13e Compare February 28, 2024 08:22
SystemKeeper
SystemKeeper reviewed Feb 28, 2024
View reviewed changes
docs/chat.md Outdated Show resolved Hide resolved
SystemKeeper
SystemKeeper approved these changes Feb 28, 2024
View reviewed changes
lib/Controller/ChatController.php Outdated Show resolved Hide resolved
@SystemKeeper
Copy link
Contributor

Failing test at https://github.com/nextcloud/spreed/actions/runs/8077334985/job/22067532388?pr=11664#step:14:447

@nickvergessen nickvergessen force-pushed the feat/noid/mention-federated-users branch from 677f13e to c9ef41a Compare February 28, 2024 10:15
Antreesy
Antreesy reviewed Feb 28, 2024
View reviewed changes
lib/Chat/Parser/UserMention.php
if ($mention['type'] === 'group') {
$search = 'group/' . $mention['id'];
if (
$mention['type'] === 'group' ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@nickvergessen nickvergessen force-pushed the feat/noid/mention-federated-users branch from c9ef41a to 0432244 Compare February 28, 2024 11:40
@nickvergessen nickvergessen merged commit 562b028 into main Feb 28, 2024
64 checks passed
@nickvergessen nickvergessen deleted the feat/noid/mention-federated-users branch February 28, 2024 13:12
@Antreesy Antreesy mentioned this pull request Feb 28, 2024
Merged
3 tasks
@Antreesy Antreesy mentioned this pull request Mar 11, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy left review comments

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: federation 🌐
Projects
💬 Talk team
Archived in project
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @SystemKeeper @Antreesy