Select only searched files

[skjnldsv]

Fix #2075

[codecov]

Codecov Report

Merging #9925 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9925      +/-   ##
============================================
- Coverage      52.1%   52.08%   -0.02%     
- Complexity    25910    25915       +5     
============================================
  Files          1642     1642              
  Lines         95721    95750      +29     
  Branches       1289     1290       +1     
============================================
+ Hits          49872    49874       +2     
- Misses        45849    45876      +27

Impacted Files	Coverage Δ	Complexity Δ
lib/private/BackgroundJob/JobList.php	72.84% <0%> (-6.29%)	31% <0%> (+2%)
apps/files_trashbin/lib/Trashbin.php	72.46% <0%> (-0.25%)	136% <0%> (ø)
core/js/js.js	65.53% <0%> (-0.04%)	0% <0%> (ø)
core/Command/Upgrade.php	0% <0%> (ø)	68% <0%> (+1%)	⬆️
core/ajax/update.php	0% <0%> (ø)	11% <0%> (ø)	⬇️
lib/private/Updater.php	5.31% <0%> (+0.2%)	120% <0%> (+2%)	⬆️
lib/private/legacy/template.php	30.76% <0%> (+0.44%)	42% <0%> (ø)	⬇️

[MorrisJobke]

• clicking the "select all" checkbox still selects all files and folders (I have 2 folders and 2 txt files and searched for "txt") - also a move failed by saying it could not move the folder into which I wanted to move and it also moved the other folder that was not visible in the search result

It even says "2 folder and 2 files" beside the action menu:

Yes I cleared my cache 😉

[skjnldsv]

@MorrisJobke Fixed :)

[MorrisJobke]

Sure that this should be in here 🤔 😉

[skjnldsv]

Damnit I searched for old debug!! 🙈

[juliusknorr]

Works as expected now 👍

[MorrisJobke]

Tested and works 👍

[raimund-schluessler]

Awesome, thanks @skjnldsv.

[Schmuuu]

Hello,

Is this fix only working with NC14 or should it work with NC13 as well?
Actually, I was thinking that I could just replace the changed file on my NC13.0.4 server and it perfectly solved the problem with the selection. Unfortunately, it caused another issue in NC13.0.4: Now the "Download" button in the top right corner was no longer working. And I was wondering if this will also be an issue in NC14 then or if it is only occurring in NC13.
Just asking for confirmation, in case this would be a bug in NC14 then later.

[raimund-schluessler]

Simply replacing the file will most likely not work, since there have been other changes to it since NC 13.0.4. You could try to apply the patch from this PR manually, though. Although I would recommend to wait for NC14 or to ask for a backport.

[Schmuuu]

You could try to apply the patch from this PR manually, though.
Yes, this is what I did and I ran into this issue with the Download button not working.

I wanted to mention that early on, just in case this issue exists with NC14 as well and would be discovered too late (when NC14 is released already).

Anyway: I will wait until NC14 then. Thank you.

[simonbuehler]

this still doesn't work with latest stable 14.0.3, all files in direcrory are used and not only search results