Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selecting all files in search/filter view targets whole directory instead of just the visibly selected files -> e.g. wrong files deleted #14016

Closed
nunofmds opened this issue Feb 4, 2019 · 9 comments · Fixed by #15309
Labels
Milestone

Comments

@nunofmds
Copy link

nunofmds commented Feb 4, 2019

Steps to reproduce

  1. Search for something that return multiple results
  2. Select all items
  3. Actions -> Delete

Expected behaviour

Delete only the selected items

Actual behaviour

All items on the folder get deleted

Server configuration

Operating system: Debian with Docker + linuxserver.io Image

Web server:

Database: Maria DB Latest

PHP version:

Nextcloud version: 15.0.2

Updated from an older Nextcloud/ownCloud or fresh install:

Where did you install Nextcloud from:

Signing status:

Signing status
Login as admin user into your Nextcloud and access 
http://example.com/index.php/settings/integrity/failed 
paste the results here.

List of activated apps:

App list
If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration:

Config report
If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or 

Insert your config.php content here. 
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

Are you using external storage, if yes which one: local/smb/sftp/...

Are you using encryption: yes/no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

LDAP configuration (delete this part if not used)

LDAP config
With access to your command line run e.g.:
sudo -u www-data php occ ldap:show-config
from within your Nextcloud installation folder

Without access to your command line download the data/owncloud.db to your local
computer or access your SQL server remotely and run the select query:
SELECT * FROM `oc_appconfig` WHERE `appid` = 'user_ldap';


Eventually replace sensitive data as the name/IP-address of your LDAP server or groups.

Client configuration

Browser:

Operating system:

Logs

Web server error log

Web server error log
Insert your webserver log here

Nextcloud log (data/nextcloud.log)

Nextcloud log
Insert your Nextcloud log here

Browser log

Browser log
Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...
@nunofmds nunofmds added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Feb 4, 2019
@violoncelloCH
Copy link
Member

thank you for reporting
could you please clarify what you select and what gets deleted instead?

@nunofmds
Copy link
Author

nunofmds commented Feb 5, 2019

Go to any folder with some files, search for something that returns more than one result, select all results with the box select on top bar and go to actions delete... All files of the folder will get deleted and not only the selected ones.

@kesselb
Copy link
Contributor

kesselb commented Feb 5, 2019

#1274
#9925

Could be a regression 🤔

@kubco2
Copy link

kubco2 commented Feb 8, 2019

This breaks also downloading selected files.
Search something with more results in directory. Select all > download, instead downloading selected files, whole directory is downloaded. But if you unselect one item and select it again, so no "all" checkbox checked, only selected files are downloaded.

@violoncelloCH violoncelloCH changed the title Wrong files deleted selecting all files in search/filter view targets whole directory instead of just the visibly selected files -> e.g. wrong files deleted Apr 18, 2019
@violoncelloCH violoncelloCH added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 18, 2019
@violoncelloCH
Copy link
Member

violoncelloCH commented Apr 18, 2019

managed to reproduce this even with 16.0.0RC2
cc @skjnldsv is this a regression (#9925)?

@loeffelpan
Copy link

I can confirm.
This should have been fixed with NC14 and works for some cases.

@nickvergessen nickvergessen added feature: files and removed 1. to develop Accepted and waiting to be taken care of labels Apr 29, 2019
@nickvergessen
Copy link
Member

@skjnldsv please have a look, this looks quite bad

@skjnldsv
Copy link
Member

#9925 actually solved the unselect, but not the select part. Which was already there. :/

@skjnldsv
Copy link
Member

Fix in #15309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants