Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(files) : Give a hint that names starting with dots might be hidden #43366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arublov
Copy link
Member

@arublov arublov commented Feb 5, 2024

Checklist

Before:
The file name is changed with dots at the beginning without confirmation.

After:
Now when changing a file name with a dot/s at the beginning, a confirmation will pop up first to warn the user that the file can be hidden if the name is changed.

Screenshot 2024-02-05 at 20 57 29

@arublov arublov requested a review from skjnldsv as a code owner February 5, 2024 19:59
@solracsf solracsf changed the title feature(files) : When creating a new folder give a hint that folder names starting with dots might be hidden #21609 feature(files) : Give a hint that names starting with dots might be hidden Feb 5, 2024
@solracsf solracsf requested a review from susnux February 9, 2024 08:42
@solracsf solracsf added the 3. to review Waiting for reviews label Feb 9, 2024
@solracsf solracsf added this to the Nextcloud 29 milestone Feb 9, 2024
@susnux
Copy link
Contributor

susnux commented Feb 9, 2024

This might annoy a lot of users because it is shown everytime you rename such a file, especially if you know what you are doing.

So cc @jancborchardt for UX

@ChristophWurst
Copy link
Member

As an alternative we could use something like a tooltip. It warns but doesn't get into your way. What do you think?

@jancborchardt
Copy link
Member

Yup, would agree with @ChristophWurst’s suggestion of a tooltip. Does this work @arublov @susnux?

@ChristophWurst
Copy link
Member

Apparently the dialogue for new files now looks like this:

image

This could be enhanced by a https://nextcloud-vue-components.netlify.app/#/Components/NcNoteCard with type warning right under/over the filename input.

@arublov
Copy link
Member Author

arublov commented Feb 19, 2024

Apparently the dialogue for new files now looks like this:

image

This could be enhanced by a https://nextcloud-vue-components.netlify.app/#/Components/NcNoteCard with type warning right under/over the filename input.

Yes, I already tried to implement with NcNoteCard, but if you want to rename a folder/file, it happens:

Screenshot 2024-02-19 at 4 59 13 PM

…ames starting with dots might be hidden nextcloud#21609

Signed-off-by: Andrii Rublov <[email protected]>
@arublov arublov force-pushed the feature/confirmation-when-name-with-dots branch from 35e5341 to 43212e8 Compare February 19, 2024 16:02
@arublov
Copy link
Member Author

arublov commented Feb 19, 2024

@ChristophWurst / @jancborchardt , If I do like this for renaming folders/files? The NcNoteCard will appear to the right of the input.

Screenshot 2024-02-19 at 5 25 25 PM

@arublov arublov self-assigned this Feb 28, 2024
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@joshtrichards joshtrichards added the hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. label Oct 2, 2024
@marcoambrosini
Copy link
Member

marcoambrosini commented Oct 3, 2024

About renaming warning: I think the dialog is the way to go, we just need a never show this again checkbox. This type of warning doesn't work well in a tooltip, and for most users it's actually good to break the flow be very clear about the fact that the file/folder is about to be hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress feature: files hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating a new folder give a hint that folder names starting with dots might be hidden
8 participants