Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users when changing format or renaming into hidden file #48533

Open
marcoambrosini opened this issue Oct 2, 2024 · 2 comments
Open

Warn users when changing format or renaming into hidden file #48533

marcoambrosini opened this issue Oct 2, 2024 · 2 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. overview
Milestone

Comments

@marcoambrosini
Copy link
Member

marcoambrosini commented Oct 2, 2024

We should warn users when they're changing the format or adding a dot at the beginning of the filename upon renaming.

@tobiasKaminsky and @sorbaugh, the implementation of this should be fairly straightforward, we a confirm/cancel dialog with cancel as primary action. Let's make sure the wording is the same on all platforms.

Here's a proposal:

Case 1: renaming into .dotfile
Important: we only want to show this warning if hidden files are actually hidden
Text: Adding a "." at the beginning of the file name could result in the hiding of the file. The file can be shown again by activating the "Show hidden files" option in the files settings.
Checkbox: Do not show this warning again

Case 2: renaming the file extension
Text: Changing the file extension may render the file unusable.
Checkbox: Do not show this warning again

We need to store these in the files settings. For these I would create a new settings sections named "Warnings".

@marcoambrosini marcoambrosini added 1. to develop Accepted and waiting to be taken care of overview labels Oct 2, 2024
@marcoambrosini marcoambrosini self-assigned this Oct 2, 2024
@marcoambrosini marcoambrosini added this to the Nextcloud 31 milestone Oct 2, 2024
@szaimen
Copy link
Contributor

szaimen commented Oct 2, 2024

There is already a PR that does this: #43366

@joshtrichards joshtrichards added the hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. label Oct 2, 2024
@marcoambrosini marcoambrosini moved this to 🏗️ At engineering in 🖍 Design team Oct 3, 2024
@marcoambrosini marcoambrosini moved this from 🏗️ At engineering to 📐 At design in 🖍 Design team Oct 3, 2024
@marcoambrosini marcoambrosini moved this from 📐 At design to 🏗️ At engineering in 🖍 Design team Oct 3, 2024
@tobiasKaminsky
Copy link
Member

All other warning on Android are inline the dialog:
Image

So I chose to do it similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. overview
Projects
Status: 🏗️ At engineering
Development

No branches or pull requests

4 participants