Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use Navigation and Actions from @nextcloud/files #39955

Merged
merged 4 commits into from
Aug 23, 2023
Merged

chore: use Navigation and Actions from @nextcloud/files #39955

merged 4 commits into from
Aug 23, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 18, 2023 •
edited
Loading

@skjnldsv skjnldsv self-assigned this Aug 18, 2023
@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Aug 18, 2023
@skjnldsv skjnldsv force-pushed the fix/files-lib branch 2 times, most recently from 302f696 to 54fcb69 Compare August 18, 2023 14:44
@skjnldsv skjnldsv marked this pull request as ready for review August 18, 2023 14:44
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 18, 2023
@skjnldsv skjnldsv changed the title chore: use Navigation from @nextcloud/files chore: use Navigation and Actions from @nextcloud/files Aug 18, 2023
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2023
Merged
@susnux

This comment was marked as resolved.

Sign in to view
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 23, 2023 •
edited
Loading

Found it!
Because I installed is-svg@^5 on @nextcloud/fles, it's breakingas is-svg is a pure esm module, and jest do not work with those

Refs:

EDIT: even with the 4.x.x version it fails 🤔
EDIT2: ah, you already face that issue: https://github.com/skjnldsv/sanitize-svg/pull/153/files#diff-d5a4b3a0309f2337144861084c1014523cced561eb722cb9684c63f5e41e0567R33

@skjnldsv skjnldsv mentioned this pull request Aug 23, 2023
Merged
@susnux susnux mentioned this pull request Aug 23, 2023
Closed
@skjnldsv skjnldsv mentioned this pull request Aug 23, 2023
Merged
5 tasks
@skjnldsv skjnldsv requested review from a team, susnux, artonge and Pytal and removed request for a team August 23, 2023 11:14
nickvergessen
nickvergessen approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 23, 2023
@skjnldsv skjnldsv merged commit 590b1d9 into master Aug 23, 2023
@skjnldsv skjnldsv deleted the fix/files-lib branch August 23, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files technical debt
Projects
Files to vue
Status: Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @susnux @nickvergessen