-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new Vue FilePicker from @nextcloud/dialogs
and use it by default
#39792
Conversation
82ce32b
to
d362b03
Compare
d362b03
to
a219d13
Compare
but files will use the new one right-away? |
a219d13
to
79b31b8
Compare
Correct by default the new one is used everywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6114a63
to
a66f9bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :) Only 2 additional things besides @szaimen’s points:
- The loading skeleton screen elements are too dark on the background. We had a similar issue in Mail or elsewhere, I thought it was fixed in the components?
- The "Modified" column should be left-aligned like it is now in files. Only "Size" is right-aligned as it has numbers which can extend to the left, but modified is numbers + text.
Thank you for your feedback :)
I think this is an issue with the nextcloud vue library as this is from the NcBreadcrumbs component.
Currently there is always checkboxes shown (if multiselect is enabled then there is also a select all one in the table header).
You are right, on darkmode I did not noticed it that much but I agree we should make them lighter.
Thank you, will change this :) |
Thanks @susnux! :)
I see, I can create an issue for this if you want :)
Yes, I think so :) Please dont forget my third point :)
|
a66f9bf
to
a92bb9c
Compare
Yes 😅 |
Rebasing... done! |
3d6deeb
to
fc3ec11
Compare
This comment was marked as resolved.
This comment was marked as resolved.
fc3ec11
to
cc4e20d
Compare
If the cypress user test fails with |
Added a theming fix. |
619c846
to
9c6273b
Compare
…fault. Still providing the legacy one until the Vue FilePicker is out of beta. Pin beta releases so we do not get version conflicts. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
8f0f0e5
to
5831d4f
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
should be ready to go? |
Congrats!! 🎉 🎉 🎉 |
Summary
(Still providing the legacy one until the Vue FilePicker is out of beta.)
Basically just use the new component from the dialogs package, see information in the PR nextcloud-libraries/nextcloud-dialogs#878
Screenshots
vokoscreenNG-2023-08-10_04-21-53.mp4
And on smaller screens:
TODO
Checklist