Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alt attrs for images in files versions #37363

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Fix alt attrs for images in files versions #37363

merged 1 commit into from
Mar 24, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Mar 23, 2023 •
edited
Loading

Summary

No visual changes. Set alt attr for img elements in a sidebar.

Checklist

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Mar 23, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the title Fix/36910 fix alt attrs for files versions Fix alt attrs for images in files versions Mar 23, 2023
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Mar 23, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the base branch from master to stable25 March 23, 2023 12:16
@JuliaKirschenheuter
Fix alt attrs for img in files_versions
b4c44cb 
Signed-off-by: julia.kirschenheuter <[email protected]>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36910-fix-alt-attrs-for-files-versions branch from 3e82c19 to b4c44cb Compare March 23, 2023 12:18
@ChristophWurst ChristophWurst requested a review from Antreesy March 23, 2023 15:22
Antreesy
Antreesy approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always works

@JuliaKirschenheuter JuliaKirschenheuter merged commit 8c5d12f into stable25 Mar 24, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/36910-fix-alt-attrs-for-files-versions branch March 24, 2023 08:48
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Mar 24, 2023
Closed
3 tasks
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Mar 30, 2023
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Mar 30, 2023
@skjnldsv skjnldsv mentioned this pull request Apr 13, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
4 participants
@JuliaKirschenheuter @ChristophWurst @Antreesy @skjnldsv