Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.1.1.1c/3.1 - The "Details" area / "Versions" tab - Both "preview" images and "restore" images do not have the alt attribute. To designate images as decorative images, the attribute alt="" should be used. (2) #36910

Closed
1 of 3 tasks
AndyScherzinger opened this issue Feb 28, 2023 · 3 comments · Fixed by #37363
Closed
1 of 3 tasks

[BITV] 9.1.1.1c/3.1 - The "Details" area / "Versions" tab - Both "preview" images and "restore" images do not have the alt attribute. To designate images as decorative images, the attribute alt="" should be used. (2) #36910

AndyScherzinger opened this issue Feb 28, 2023 · 3 comments · Fixed by #37363
Assignees
@JuliaKirschenheuter
Labels
3. to review Waiting for reviews accessibility
Milestone
Nextcloud 27

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Feb 28, 2023 •
edited by JuliaKirschenheuter
Loading

  • Fix
  • Backport

2023-03-20 13_25_27-Photos - Files - Nextcloud – Mozilla Firefox

example:

<img class="preview" src="/ltd/a11y/index.php/apps/files_versions/preview?file=%2FPhotos%2FReadme.md&amp;version=1675688665" width="44" height="44">

<a href="#" class="revertVersion" title="Restore"><img src="/ltd/a11y/core/img/actions/history.svg"></a>
Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-3a2875951a-v3-n1
@AndyScherzinger AndyScherzinger added 1. to develop Accepted and waiting to be taken care of accessibility labels Feb 28, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Mar 20, 2023
@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Mar 22, 2023 •
edited
Loading

On current master all decorative icons already have aria-hidden="true". Fix should be done in NC25

Screenshot from 2023-03-23 16-18-13

Screenshot from 2023-03-22 11-26-10

@JuliaKirschenheuter JuliaKirschenheuter added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Mar 22, 2023
This was referenced Mar 22, 2023
Closed
Merged
@JuliaKirschenheuter
Copy link
Contributor

For NC26+ is nothing to do, already implemented.

Note:In Chrome an empty alt attr won't be shown right! Double check in (for example) Firefox:

Firefox:
Screenshot from 2023-03-23 16-13-14

Chrome:
Screenshot from 2023-03-23 16-16-14

@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 23, 2023
@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Mar 24, 2023 •
edited
Loading

Fix:

Backports:
No backports needed

@AndyScherzinger AndyScherzinger added this to the Nextcloud 27 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
Nextcloud 27
2 participants
@AndyScherzinger @JuliaKirschenheuter