Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated occ app:check-code command #32210

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Apr 28, 2022

The command does nothing and outputs:

The app code checker doesn\t check anything and this command will be removed in Nextcloud 23

Signed-off-by: Côme Chilliet [email protected]

@come-nc come-nc added the 3. to review Waiting for reviews label Apr 28, 2022
@come-nc come-nc added this to the Nextcloud 25 milestone Apr 28, 2022
@come-nc come-nc self-assigned this Apr 28, 2022
@come-nc come-nc requested review from a team, ArtificialOwl, juliusknorr and CarlSchwan and removed request for a team April 28, 2022 13:10
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@come-nc
Copy link
Contributor Author

come-nc commented Apr 28, 2022

Drone failure unrelated

@come-nc come-nc merged commit 1227278 into master Apr 28, 2022
@come-nc come-nc deleted the fix/remove-deprecated-occ-app-check-code-command branch April 28, 2022 14:44
@ajs124 ajs124 mentioned this pull request Oct 23, 2022
13 tasks
@ChristophWurst
Copy link
Member

The command does nothing and outputs

#25577 well intended. I just forgot to remove the command later on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants