Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud25: init #197386

Merged
merged 1 commit into from
Oct 23, 2022
Merged

nextcloud25: init #197386

merged 1 commit into from
Oct 23, 2022

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 23, 2022

Description of changes

As always, I'd file a backport PR with the non-breaking changes.
Also, removed nextcloud23 because it'll reach its end of life within 22.11.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 23, 2022
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 23, 2022
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Oct 23, 2022
@ofborg ofborg bot requested review from schneefux, globin and bachp October 23, 2022 15:48
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Oct 23, 2022
RaitoBezarius
RaitoBezarius approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

yayayayaka
yayayayaka approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajs124
Copy link
Member

ajs124 commented Oct 23, 2022

The only relevant change for admins according to nextcloud/server#32117 seems to be nextcloud/server#32210, which we don't use.

@ajs124 ajs124 merged commit 16d6140 into NixOS:master Oct 23, 2022
@Ma27 Ma27 deleted the nextcloud25 branch October 23, 2022 21:07
Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Oct 24, 2022
@Ma27
nextcloud25: init
94323f6 
This is a non-breaking change because the default version installed by
`services.nextcloud` remains `pkgs.nextcloud24`, but it gives users a
chance to upgrade to v25 on 22.05.

I also left `pkgs.nextcloud23` in here because it will only be dropped
in 2022-12 which is also the EOL of 22.05.

The corresponding change in `master` is at
40b7f52 from PR NixOS#197386.
@Ma27 Ma27 mentioned this pull request Oct 24, 2022
Merged
13 tasks
@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yayayayaka yayayayaka yayayayaka approved these changes

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@ajs124 ajs124 Awaiting requested review from ajs124

@urandom2 urandom2 Awaiting requested review from urandom2

@danth danth Awaiting requested review from danth

@schneefux schneefux Awaiting requested review from schneefux

@globin globin Awaiting requested review from globin

@bachp bachp Awaiting requested review from bachp

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ma27 @ajs124 @RaitoBezarius @yayayayaka