Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vendor loading in user_ldap wizard #31756

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Mar 30, 2022

Introduced by #31174 that was fixing the load order of the scripts. The jQuery plugin was loaded before jQuery, and I didn't check if the style was correctly loaded.

Fix: #31755

@artonge artonge requested review from a team, PVince81, skjnldsv and szaimen and removed request for a team March 30, 2022 12:15
@artonge artonge self-assigned this Mar 30, 2022
@artonge artonge added this to the Nextcloud 24 milestone Mar 30, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 requested a review from blizzz March 30, 2022 14:17
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 30, 2022
@blizzz blizzz merged commit 72b8deb into master Mar 30, 2022
@blizzz blizzz deleted the fix/vendor_loading_ldap branch March 30, 2022 14:26
@blizzz blizzz mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LDAP wizard group attribute dropdown is broken
4 participants