Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script loading in ldap's settings #31174

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Feb 14, 2022

jquery.multiselect was loaded before jQuery, breaking the ldap settings UI

@artonge artonge added the bug label Feb 14, 2022
@artonge artonge added this to the Nextcloud 24 milestone Feb 14, 2022
@artonge artonge self-assigned this Feb 14, 2022
@artonge artonge requested review from a team, PVince81, Pytal and szaimen and removed request for a team February 14, 2022 15:58
@artonge artonge requested a review from come-nc February 14, 2022 17:24
@Pytal Pytal added the 4. to release Ready to be released and/or waiting for tests to finish label Feb 15, 2022
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it does fix the problem 👌

@come-nc come-nc merged commit 77ed32b into master Feb 15, 2022
@come-nc come-nc deleted the fix/script_loading_ldap branch February 15, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants