-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move font from Nunito to Noto Sans for character set compatibility #16040
Conversation
:)),but not Noto Sans, it Noto Sans TC. (TC=Traditional Chinese) |
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
The plan for Simplified Chinese, Traditional Chinese, Japanese, and Korean is the following:
Does that sounds like it make sense – before I start doing that? :D @skjnldsv @chiyi4488 @HuidaeCho |
9ad77f9
to
d14c0f2
Compare
@skjnldsv addressed your comments and fixed the erroneous commit of the loading colors. :) The Drone failures seem unrelated? Anything else? :) |
😱 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot really test all foreign glyphs, but it looks good 👍 🚀
I will test it recently. How can I get this change? |
@chiyi4488 are you familiar with git? You then could clone the repositiry and check out this branch. But note that we don't have the Noto Sans CJK in here yet, I will add that in a follow-up pull request. :) |
We could also additionally test how Source Sans Pro looks: As the Chinese-Japanese-Korean character sets are a collab between Noto (Google) and Source (Adobe) they will look good for both. However, if we use Source Sans Pro in the web interface, then we should do so too on the website, business cards and promo material. (It's not a bit change though as the fonts are very similar anyway.) |
Another possibility, because on Android and iOS we also use the native fonts rather than some custom font: We could use e.g.:
EDIT: Seems that Github, Medium and Wordpress do this since some time already: https://css-tricks.com/snippets/css/system-font-stack/#article-header-id-1 |
I don't know what you mean. |
I can't see any style preview(chinese |
@chiyi4488 as said, CJK is not in this pull request. :) |
Pull request for using a native font stack in the web interface at #16055 – please test and review. :) |
Re-opened #4198 because as far as I can tell CJK support was never added for MD/TXT previews/thumbnails. Looks like we'd have to bundle additional Noto woff2 files plus maybe build some logic into the MD/TXT preview generator. |
Noto Sans is very similar to Open Sans which we used before – and still use on business cards, website and all promo material because we never switched as Nunito didn’t look good for that.
Additionally, Noto Sans supports a lot more character sets. Which is important for our global userbase and goal of being an alternative for everyone.
The detailed reasons for the switch are:
Nunito drawbacks:
Noto Sans advantages:
Note that this pull request first starts with adding a base of the acharacter sets like Latin, Cyrillic, Vietnamese, Greek and Devanagari – the same you would get when embedding Noto Sans via Google Fonts.
Korean/Hangul, Chinese and others we will do in a follow-up pull request.
Please review @nextcloud/designers @chiyi4488 @R0maNNN @KekcuHa @kesselb @hbqclh @HuidaeCho and cc @jospoortvliet FYI regarding the screenshots for the release. 🎉