Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heterogeneous fonts in the whole interface #13377

Closed
1ndahous3 opened this issue Jan 5, 2019 · 16 comments
Closed

Heterogeneous fonts in the whole interface #13377

1ndahous3 opened this issue Jan 5, 2019 · 16 comments
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc.
Milestone

Comments

@1ndahous3
Copy link

1ndahous3 commented Jan 5, 2019

NC 15.0.0 (Docker)
Firefox 64.0 on Windows 10

Difference between English and Russian

image

3 different fonts in the sentence

image

@1ndahous3 1ndahous3 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 5, 2019
@kesselb
Copy link
Contributor

kesselb commented Jan 5, 2019

@nextcloud/designers

@jancborchardt
Copy link
Member

@R0maNNN thanks a lot for the report! :) It seems that these are many issues which can all be treated separately. Could you open separate issues for them? That will help them getting fixed quicker without one blocking the others. Thanks a lot!

@jancborchardt
Copy link
Member

Oh and also, could you zoom in a bit when you take the screenshots so it’s easier to see the typeface differences? Thanks! :)

@jancborchardt jancborchardt added design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Jan 9, 2019
@1ndahous3
Copy link
Author

1ndahous3 commented Jan 9, 2019

@jancborchardt split, description of this issue edited (I think it's the same problem).

Digits in the hint: #13466

@jancborchardt
Copy link
Member

@R0maNNN thanks! You also had a thing about the font-size of the date in the Activity app? Could be opened in https://github.com/nextcloud/activity/issues/

@jancborchardt
Copy link
Member

And back to this issue. :) Of course the problem is that Nunito, the font we use, does not support Cyrillic. Some options:

  • It seems mainly the issue is that the Cyrillic font is a bit smaller. We could increase that but I have no idea how to check for that and it sounds like a recipe for layout mess.
  • Is there a version of Nunito with a Cyrillic character set?
  • Can you check if Open Sans (we used that before) or Noto Sans supports Cyrillic? Maybe this whole switch to Nunito was just a mistake and we need to go back.

Other thoughts @nextcloud/designers?

@jancborchardt jancborchardt removed the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Jan 10, 2019
@kesselb
Copy link
Contributor

kesselb commented Jan 10, 2019

In November 2017 Nunito has been expanded to GF Cyrillic Pro by Manvel Shmavonyan, and Alexei Vanyashin.

https://github.com/googlefonts/nunito 🤔

@1ndahous3
Copy link
Author

Can you check if Open Sans (we used that before) or Noto Sans supports Cyrillic? Maybe this whole switch to Nunito was just a mistake and we need to go back.

I can say that there is no such problem in NC 14

@juliusknorr
Copy link
Member

@jancborchardt It seems that the fonts added with #11932 in server are not the latest ones from the googlefonts/nunito repo

sha256sum core/fonts/Nunito-Regular.ttf
96a2bf793dd663407f49bcd219fe5abca8d52ce98d47b6063e3843db5d17bcdd
sha256sum ~/Downloads/Nunito-Regular.ttf
f13b35daecf71d80d0df39e0f7bf6e99108a4516f38f682b52294090729f2fee

@jancborchardt
Copy link
Member

@juliushaertl good find! @danielkesselberg do you want to update the fonts in the repository? :)

@kesselb
Copy link
Contributor

kesselb commented Jan 11, 2019

Sure @jancborchardt but after some research this looks more complicated 🤔

If you downloaded the font from https://fonts.google.com/specimen/Nunito then we currently serve v3.001 (https://github.com/google/fonts/tree/master/ofl/nunito). That is the version without cyrillic.

There is already a pull request (not merged yet) to update the font to v3.502 (google/fonts#1549) from the upstream repository. This should add cyrillic and solve some other issues (https://github.com/google/fonts/labels/z_Nunito).

Grabbed the fonts from the pull request and used https://github.com/google/woff2 to create .woff2 but this tool does not support unicode range (didnt know that something like that exists pretty cool actually). I read https://developers.googleblog.com/2015/02/smaller-fonts-with-woff-20-and-unicode.html but still dont know the right way to create these woff2 files 😕

@jancborchardt
Copy link
Member

Hmm, I also have no idea how we would create these woff2 files. Once the pull request google/fonts#1549 is merged, would Google Fonts generate them so we simply have to wait?

Thanks for all the digging @danielkesselberg!

@skjnldsv
Copy link
Member

skjnldsv commented Jun 5, 2019

@jancborchardt what is the status here, approve or reject! 👩‍⚖️

@skjnldsv skjnldsv added needs info 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jun 5, 2019
@skjnldsv
Copy link
Member

TODO: bump nunito
TODO: find a font that have cyrillic

@jancborchardt
Copy link
Member

There is now a pull request to move to Noto Sans to fix all these issues with unsupported character sets. Please review it at #16040 :)

@jancborchardt
Copy link
Member

We now use a native font stack as per #16055, so things will look heterogenous for Nextcloud 17 🎉

@jancborchardt jancborchardt added this to the Nextcloud 17 milestone Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc.
Projects
None yet
Development

No branches or pull requests

5 participants