Add fopen method to ISimpleFile #10122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I would prefer having separate read and write methods instead of a generic fopen |
MorrisJobke
added
2. developing
juliusknorr
force-pushed
the
feature/noid/appdata-fopen-stream
branch
from
370fdfd to
8100a14
Compare
|
@icewind1991 I moved it to two separate methods. |
MorrisJobke
reviewed
Jul 11, 2018
| * @since 14.0.0 | ||
| */ | ||
| public function fopen(string $mode) { | ||
| } |
There was a problem hiding this comment.
Sorry, forgot to remove this. 🙈 Fixed.
There was a problem hiding this comment.
Hm Github doesn't show my rebased commits, but when forcepushing everything is up to date :/
There was a problem hiding this comment.
OK, another commit --amend fixed it.
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
feature/noid/appdata-fopen-stream
branch
from
2efeed5 to
6da2b7c
Compare
MorrisJobke
added
3. to review
icewind1991
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to also use the AppData for large files where using a FileDisplayResponse will fail, because it is calling getContent and trying to put the whole file in memory.
With this, apps can properly use a StreamResponse.