Fetch file from rootFolder instead of IAppData to use StreamResponse #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when displaying Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/stream-attachment-download
branch
from
c5be2b1 to
cb25643
Compare
Codecov Report
@@ Coverage Diff @@
## master #519 +/- ##
==========================================
+ Coverage 80.34% 80.41% +0.06%
==========================================
Files 45 45
Lines 1496 1511 +15
==========================================
+ Hits 1202 1215 +13
- Misses 294 296 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the download of huge attachments, where the whole file was put in memory. This PR adds a workaround to manually get the file using IRootFolder instead of IAppData, so we can stream the file.
A proper fix would be to use fopen, which can be used once nextcloud/server#10122 is available in the supported Nextcloud versions.