Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: After upgrade 27.0.x->27.1.0 public-type shares (web link) with self-generated password don't work #40493

Closed
5 of 8 tasks
Tracked by #40438
dea-75 opened this issue Sep 19, 2023 · 13 comments · Fixed by #40533
Closed
5 of 8 tasks
Tracked by #40438
Assignees
Labels

Comments

@dea-75
Copy link

dea-75 commented Sep 19, 2023

⚠️ This issue respects the following points: ⚠️

Bug description

Hi all,
I just upgraded to version 27.1.0 from the previous last version of 27.0.x and a problem came up (upgrade all ok).
When I generate a public share (web link) having set up forced password usage a random password is (correctly) generated.
Process that has always worked correctly on version 27.0.x.
However, the automatic password appears to have expired a few seconds ago.
If I set a password by typing it in, it works correctly.

PLEASE NOTE:

the problem occurs ONLY on links with automatically generated password on version 27.1.0.
If the link was previously generated (27.0.x or 26.0.x) there is no problem.
The same behavior has been verified on two different servers.

Steps to reproduce

1.I create a public share
2.An automatic password is assigned (because it is forced)
3.Sharing appears to have expired a few seconds ago

If I set a password manually (overwriting the automatic one) it works correctly.

Expected behavior

That the link is working properly

Installation method

Community Manual installation with Archive

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 22.1 to 22.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@dea-75 dea-75 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Sep 19, 2023
@szaimen
Copy link
Contributor

szaimen commented Sep 19, 2023

cc @fenn-cs @sorbaugh

@sorbaugh
Copy link
Contributor

Hi!

Thanks for reporting this issue and for providing detailed steps. We've attempted to reproduce the issue following your steps, but we're encountering some difficulty in replicating it on our end. Can you provide us some additional information that could help us further diagnose the problem? For example, are you getting any specific error messages (screenshots are awesome)? What Browser/Version are you using?

@dea-75
Copy link
Author

dea-75 commented Sep 19, 2023

Hi!

Thanks for reporting this issue and for providing detailed steps. We've attempted to reproduce the issue following your steps, but we're encountering some difficulty in replicating it on our end. Can you provide us some additional information that could help us further diagnose the problem? For example, are you getting any specific error messages (screenshots are awesome)? What Browser/Version are you using?

Hi !

Screenshot_20230919_150151

this is the screenshot with the error display.
Sorry for the mixed language (ita/eng).

"scadenza password alcuni secondi fa " => "password expiration a few seconds ago "

Keep in mind that the problem was verified on both edge and chrome, on two different servers.

@dea-75
Copy link
Author

dea-75 commented Sep 19, 2023

Hi!

Thanks for reporting this issue and for providing detailed steps. We've attempted to reproduce the issue following your steps, but we're encountering some difficulty in replicating it on our end. Can you provide us some additional information that could help us further diagnose the problem? For example, are you getting any specific error messages (screenshots are awesome)? What Browser/Version are you using?

A clarification:
-) the problem occurs only during mail link sharing (during the generation of sharing with mail link sending)
-) as shown in the screenshot above, going to the advanced options
-) the automatically generated password turns out to be expired, so if you directly press the "proceed" button you will be notified that the random password you just created has expired
-) If you edit by hand, everything works smoothly

@xprntb3
Copy link

xprntb3 commented Sep 20, 2023

Hi!
Thanks for reporting this issue and for providing detailed steps. We've attempted to reproduce the issue following your steps, but we're encountering some difficulty in replicating it on our end. Can you provide us some additional information that could help us further diagnose the problem? For example, are you getting any specific error messages (screenshots are awesome)? What Browser/Version are you using?

A clarification: -) the problem occurs only during mail link sharing (during the generation of sharing with mail link sending) -) as shown in the screenshot above, going to the advanced options -) the automatically generated password turns out to be expired, so if you directly press the "proceed" button you will be notified that the random password you just created has expired -) If you edit by hand, everything works smoothly

I am having the exact same Issue as described in this post with the current version.
Also like OP i am using another language than english

@nfebe
Copy link
Contributor

nfebe commented Sep 20, 2023

A clarification:
-) the problem occurs only during mail link sharing (during the generation of sharing with mail link sending)
-) as shown in the screenshot above, going to the advanced options
-) the automatically generated password turns out to be expired, so if you directly press the "proceed" button you will be notified that the random password you just created has expired
-) If you edit by hand, everything works smoothly

Thanks for the additional context. Looking at it.

@nfebe nfebe added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 20, 2023
nfebe added a commit that referenced this issue Sep 20, 2023
Suggest autogenerated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Sep 20, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Sep 20, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
@nfebe nfebe moved this to 🏗️ In progress in 📁 Files team Sep 20, 2023
nfebe added a commit that referenced this issue Sep 20, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Sep 20, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Sep 20, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Sep 20, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Sep 20, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Sep 21, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
@dea-75
Copy link
Author

dea-75 commented Sep 21, 2023

A clarification:
-) the problem occurs only during mail link sharing (during the generation of sharing with mail link sending)
-) as shown in the screenshot above, going to the advanced options
-) the automatically generated password turns out to be expired, so if you directly press the "proceed" button you will be notified that the random password you just created has expired
-) If you edit by hand, everything works smoothly

Thanks for the additional context. Looking at it.

I understand that the problem has been identified and solved.
How do I download the modified files (or diffs) to apply to version 27.1.0 in production ?

Very thanks

@nfebe
Copy link
Contributor

nfebe commented Sep 21, 2023

I understand that the problem has been identified and solved.
How do I download the modified files (or diffs) to apply to version 27.1.0 in production ?

Very thanks

It would get released in 27.1.1 which should be available for download/update early next week, worst case. :)

@dea-75
Copy link
Author

dea-75 commented Sep 21, 2023

I understand that the problem has been identified and solved.
How do I download the modified files (or diffs) to apply to version 27.1.0 in production ?
Very thanks

It would get released in 27.1.1 which should be available for download/update early next week, worst case. :)

OK, 27.1.1 now works but:
immagine

Show again ""password expired a few seconds ago ""
but unlike before it works correctly without manually resetting the password.

Only the warning appears that the pre set random password + expired.

@nfebe
Copy link
Contributor

nfebe commented Sep 21, 2023

Only the warning appears that the pre set random password + expired.

While I would confirm this later, please @dea-75 clear you cache (if enabled) and report if anything changes.

Thanks for the follow up.

@nfebe
Copy link
Contributor

nfebe commented Sep 21, 2023

@dea-75, Right, would be sorted out.

@nfebe
Copy link
Contributor

nfebe commented Sep 21, 2023

Since this commit has already been back-ported this last been would be shipped in with #40438.

@nfebe nfebe closed this as completed Sep 21, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Sep 21, 2023
@nfebe nfebe reopened this Sep 21, 2023
@github-project-automation github-project-automation bot moved this from ☑️ Done to 📄 To do (~10 entries) in 📁 Files team Sep 21, 2023
nfebe added a commit that referenced this issue Sep 21, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
@dea-75
Copy link
Author

dea-75 commented Sep 21, 2023

Since this commit has already been back-ported this last been would be shipped in with #40438.

I can confirm.

Browser chrome, reset cache, same problem on 27.1.1.
There isn't problem and the password works but the alert persist...
"password expired a few seconds ago "

nfebe added a commit that referenced this issue Sep 22, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Sep 23, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nextcloud-command pushed a commit that referenced this issue Sep 23, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command pushed a commit that referenced this issue Sep 23, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
nfebe added a commit that referenced this issue Sep 25, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nfebe added a commit that referenced this issue Sep 26, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
nextcloud-command pushed a commit that referenced this issue Sep 26, 2023
Suggest auto generated password for new public share (mail share).

Resolves : #40493

Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📁 Files team Sep 26, 2023
zak39 pushed a commit to arawa/server that referenced this issue Oct 11, 2023
Suggest auto generated password for new public share (mail share).

Resolves : nextcloud#40493

Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
zak39 pushed a commit to zak39/server that referenced this issue Dec 19, 2023
Suggest auto generated password for new public share (mail share).

Resolves : nextcloud#40493

Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants