Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛑️ Polishing for new sharing design and flow -> 27.1.3 #40438

Closed
7 tasks done
sorbaugh opened this issue Sep 15, 2023 · 5 comments · Fixed by #40629
Closed
7 tasks done

⛑️ Polishing for new sharing design and flow -> 27.1.3 #40438

sorbaugh opened this issue Sep 15, 2023 · 5 comments · Fixed by #40629
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback enhancement

Comments

@sorbaugh
Copy link
Contributor

sorbaugh commented Sep 15, 2023

This is a follow up to #40172 where the blocking issues were resolved for 27.1.0. Below are the enhancements planned for 27.1.1 and 27.1.2

  • The "Cancel" and primary button on the bottom need a backdrop to separate them a bit from the background, best a fade from color-main-background on the bottom to transparent on the top.
  • Currently links are sorted below emails once created, but sorting should be: Links, mails, users
  • QA: Needs side by side testing if all old options are possible or also properly limited with the new one
  • If allow public upload admin setting is unchecked we should rename "Allow upload and editing" to "allow editing" and file drop / create permission should be disabled state
  • The content of the sidebar is scroll-able when it should only be the content of the share tab
    image
  • It is confusing to have the download permission under "Custom permissions" as it is not taken into account for bundles
  • Do not show unnecessary password expired message #40493
@nfebe
Copy link
Contributor

nfebe commented Sep 20, 2023

It is confusing to have the download permission under "Custom permissions" as it is not taken into account for bundles

@artonge Please, what is the action point for this? It needs clarification

The "Cancel" and primary button on the bottom need a backdrop to separate them a bit from the background, best a fade from color-main-background on the bottom to transparent on the top.

Not clear to me.

The content of the sidebar is scroll-able when it should only be the content of the share tab

Does not scroll like that for me, any information on how to make it happen?

Currently links are sorted below emails once created, but sorting should be: Links, mails, users

Not the case (Missing context?).
Screenshot from 2023-09-20 17-45-23

cc: @AndyScherzinger @jancborchardt @juliushaertl

@artonge
Copy link
Contributor

artonge commented Sep 20, 2023

@artonge Please, what is the action point for this? It needs clarification

It is not a file permission, but a setting of the share. You have to select custom permissions to be able to toggle it. If you toggle the download checkbox, the permissions summary is not changed. All of that is weird.

@blizzz blizzz removed this from the Nextcloud 27.1.1 milestone Sep 21, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 27.1.2 milestone Sep 21, 2023
@AndyScherzinger AndyScherzinger changed the title ⛑️ Polishing for new sharing design and flow -> 27.1.1 ⛑️ Polishing for new sharing design and flow -> 27.1.2 Sep 21, 2023
@Ornanovitch
Copy link
Contributor

Ornanovitch commented Sep 26, 2023

Hi, thanks for those improvements. There is also this strange layout when in custom mode:

  • buttons are floating on overflow
  • delete button has a white background on dark mode, and it's weird to see it as such a dominating "first possible action" above cancel and update, which are more common

Screenshot 2023-09-26 at 10-14-42 CPG - Fichiers - Brume

A last comment, but this is only my opinion:

Screenshot 2023-09-26 at 10-22-02 coordination - Fichiers - Brume

I think it is disturbing to see this new box only after selecting the Custom mode. This sudden appearance can led the user to think this is "where it happens", while this is just another presentation of the previous dropdown:

Screenshot 2023-09-26 at 10-26-23 CPG - Fichiers - Brume

I hope you'll understand this point.

Best

@AndyScherzinger
Copy link
Member

Thanks for the feedback @Ornanovitch

looping in @nextcloud/designers for feedback on #40438 (comment) - Thanks

@nfebe
Copy link
Contributor

nfebe commented Sep 26, 2023

Thanks for the feedback @Ornanovitch ....

Those are being improved here : #40629

cc: @AndyScherzinger

@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Oct 2, 2023
@AndyScherzinger AndyScherzinger changed the title ⛑️ Polishing for new sharing design and flow -> 27.1.2 ⛑️ Polishing for new sharing design and flow -> 27.1.3 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback enhancement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants