Sharing a password protected file with a note by mail generates three mails

[torstenbunde]

Steps to reproduce

1. Login as user and choose a file to share
2. Enter a mail address. A mail will be send to this user that a file is shared with him/her.
3. Set a password for this file and a second mail containing the password will be send to this user.
4. Add a note to this share and a third mail will be send to this user.

Expected behaviour

Choose a file to be send by mail, add password protection and also a note for the user and only one mail should be send.

Actual behaviour

See steps to reproduce. It's not possible to do this action in one step, instead three steps are necessary and three mails are sent.

I don't know if this might be a bug or a feature ;) Of course it's possible to share a file by using a password protected link and write a mail by yourself. But if there is the possibility to send such a mail directly through Nextcloud I think it should be possible to use it as users may expect it (one mail, not three mails).

Server configuration

Operating system: Debian 9.5

Web server: Apache 2.4.25

Database: MySQL 5.7.21

PHP version: 7.0.30

Nextcloud version: 14.0.1

Updated from an older Nextcloud/ownCloud or fresh install: Updated from 13.0.6

Where did you install Nextcloud from: Directly from the maintainers website.

Signing status:

Signing status

No errors have been found.

List of activated apps:

App list

Enabled:
  - accessibility: 1.0.1
  - bruteforcesettings: 1.1.0
  - cloud_federation_api: 0.0.1
  - comments: 1.4.0
  - dav: 1.6.0
  - federatedfilesharing: 1.4.0
  - federation: 1.4.0
  - files: 1.9.0
  - files_pdfviewer: 1.3.2
  - files_rightclick: 0.8.4
  - files_sharing: 1.6.2
  - files_texteditor: 2.6.0
  - files_trashbin: 1.4.1
  - files_versions: 1.7.1
  - files_videoplayer: 1.3.0
  - firstrunwizard: 2.3.0
  - gallery: 18.1.0
  - groupfolders: 1.3.3
  - logreader: 2.0.0
  - lookup_server_connector: 1.2.0
  - nextcloud_announcements: 1.3.0
  - notes: 2.4.2
  - notifications: 2.2.1
  - oauth2: 1.2.1
  - password_policy: 1.4.0
  - provisioning_api: 1.4.0
  - serverinfo: 1.4.0
  - sharebymail: 1.4.0
  - support: 1.0.0
  - survey_client: 1.2.0
  - systemtags: 1.4.0
  - theming: 1.5.0
  - twofactor_backupcodes: 1.3.1
  - updatenotification: 1.4.1
  - user_ldap: 1.4.0
  - workflowengine: 1.4.0
Disabled:
  - activity
  - admin_audit
  - encryption
  - files_antivirus
  - files_external
  - spreed
  - user_external

Nextcloud configuration:

Config report

{
    "system": {
        "default_language": "de",
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***"
        ],
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "14.0.1.1",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "auth.bruteforce.protection.enabled": false,
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
        "proxy": "***REMOVED SENSITIVE VALUE***",
        "skeletondirectory": "",
        "lost_password_link": "disabled",
        "mail_smtpmode": "sendmail",
        "mail_smtpauthtype": "LOGIN",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "logfile": "\/var\/log\/nextcloud\/nextcloud.log",
        "maintenance": false,
        "theme": "",
        "loglevel": 2
    }
}

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: ActiveDirectory

LDAP configuration (delete this part if not used)

LDAP config

+-------------------------------+-----------------------------------------------------------------------------------------+
| Configuration                 |                                                                                         |
+-------------------------------+-----------------------------------------------------------------------------------------+
| hasMemberOfFilterSupport      | 1                                                                                       |
| hasPagedResultSupport         |                                                                                         |
| homeFolderNamingRule          |                                                                                         |
| lastJpegPhotoLookup           | 0                                                                                       |
| ldapAgentName                 | ***REMOVED SENSITIVE VALUE***                                                           |
| ldapAgentPassword             | ***REMOVED SENSITIVE VALUE***                                                           |
| ldapAttributesForGroupSearch  |                                                                                         |
| ldapAttributesForUserSearch   |                                                                                         |
| ldapBackupHost                |                                                                                         |
| ldapBackupPort                |                                                                                         |
| ldapBase                      | ***REMOVED SENSITIVE VALUE***                                                           |
| ldapBaseGroups                | ***REMOVED SENSITIVE VALUE***                                                           |
| ldapBaseUsers                 | ***REMOVED SENSITIVE VALUE***                                                           |
| ldapCacheTTL                  | 600                                                                                     |
| ldapConfigurationActive       | 1                                                                                       |
| ldapDefaultPPolicyDN          |                                                                                         |
| ldapDynamicGroupMemberURL     |                                                                                         |
| ldapEmailAttribute            | mail                                                                                    |
| ldapExperiencedAdmin          | 0                                                                                       |
| ldapExpertUUIDGroupAttr       |                                                                                         |
| ldapExpertUUIDUserAttr        |                                                                                         |
| ldapExpertUsernameAttr        | cn                                                                                      |
| ldapGidNumber                 | gidNumber                                                                               |
| ldapGroupDisplayName          | cn                                                                                      |
| ldapGroupFilter               | (|(cn=nextcloud))                                                                       |
| ldapGroupFilterGroups         | nextcloud                                                                               |
| ldapGroupFilterMode           | 0                                                                                       |
| ldapGroupFilterObjectclass    |                                                                                         |
| ldapGroupMemberAssocAttr      | uniqueMember                                                                            |
| ldapHost                      | ***REMOVED SENSITIVE VALUE***                                                           |
| ldapIgnoreNamingRules         |                                                                                         |
| ldapLoginFilter               | (&(&(|(objectclass=user)(objectclass=contact)))(|(samaccountname=%uid)(|(mail=%uid))))  |
| ldapLoginFilterAttributes     |                                                                                         |
| ldapLoginFilterEmail          | 1                                                                                       |
| ldapLoginFilterMode           | 1                                                                                       |
| ldapLoginFilterUsername       | 1                                                                                       |
| ldapNestedGroups              | 0                                                                                       |
| ldapOverrideMainServer        |                                                                                         |
| ldapPagingSize                | 500                                                                                     |
| ldapPort                      | 389                                                                                     |
| ldapQuotaAttribute            |                                                                                         |
| ldapQuotaDefault              |                                                                                         |
| ldapTLS                       | 0                                                                                       |
| ldapUserAvatarRule            | default                                                                                 |
| ldapUserDisplayName           | displayname                                                                             |
| ldapUserDisplayName2          |                                                                                         |
| ldapUserFilter                | ***REMOVED SENSITIVE VALUE***                                                           |
| ldapUserFilterGroups          | nextcloud                                                                               |
| ldapUserFilterMode            | 0                                                                                       |
| ldapUserFilterObjectclass     |                                                                                         |
| ldapUuidGroupAttribute        | auto                                                                                    |
| ldapUuidUserAttribute         | auto                                                                                    |
| turnOffCertCheck              | 0                                                                                       |
| turnOnPasswordChange          | 0                                                                                       |
| useMemberOfToDetectMembership | 1                                                                                       |
+-------------------------------+-----------------------------------------------------------------------------------------+

Client configuration

Browser: Firefox 62.0.3, Google Chrome 69.0, Internet Explorer 11, Microsoft Edge 42

Operating system: Windows 10 Enterprise

[nextcloud-bot]

GitMate.io thinks possibly related issues are #3457 (Share by mail breaks File Sharing), #5233 (Share password by mail send on behalf issue), #2357 (Sharing a file via email and password protect the link), #3303 (Generate random password for file sharing), and #4078 (sharing by mail doesn't allow password, expiration date, secure drop).

[skjnldsv]

Yeah, this is an issue superseded by #13229