Ability to set permissions before sharing

[jancborchardt]

Done

• Android
• iOS
• Desktop
• Web UI

In the past we often talked about one of the core issues of our very easy share flow: You basically share with edit permissions always, and have to adjust later. This results in a small window where people could change or delete stuff.

This proposal fixes this very simply by adding an indicator of the current setting in the sharing input:

• ✏ Allow editing (default)
• 👁️ Read-only

Now when you change this current setting, it could be remembered. Either for the session only, per file/folder or simply globally. We can discuss what’s best and most feasible.

This is the code I used in the mockup (based on Personal settings federation dropdown ;), if anyone wants to start implementing it:

<div class="">
    <span class="icon-rename">
    	<span class="icon-triangle-s"></span>
    </span>
    <div class="popovermenu bubble menu menu-right">
        <ul>
        	<li>
        		<a href="#" class="menuitem permanent">
        				<span class="icon-rename"></span>
        			<p>
        				<strong class="menuitem-text">Allow editing</strong><br>
        				<span class="menuitem-text-detail">Recipients will be able to edit and reshare</span>
        			</p>
        		</a>
        	</li>
        	<li>
        		<a href="#" class="menuitem permanent">
        				<span class="icon-toggle"></span>
        			<p>
        				<strong class="menuitem-text">Read-only</strong><br>
        				<span class="menuitem-text-detail">Recipients will not be able to change anything</span>
        			</p>
        		</a>
        	</li>
        </ul>
    </div>
</div>

What do you think @nextcloud/designers @MorrisJobke @rullzer?

If we go forward with this, it’s also something we need to align in the desktop client and mobile apps: @nextcloud/ios @nextcloud/desktop @nextcloud/android

[rullzer]

This looks surprisingly similar to a discussion I once had with @LukasReschke ;)

I think it is a huge step forward. In general even like the more explicit flow. (like dropbox/google have, where you can fine tune it even more in a modal etc. But other discussion).

Anyway. Yes please! Being able to set the permissions beforehand would be awesome!

[violoncelloCH]

This is the code I used in the mockup (based on Personal settings federation dropdown ;), if anyone wants to start implementing it:

shouldn't we use Vue.js for this popup? We have the PopoverMenu component for this. cc @nextcloud/vue

[juliusknorr]

@violoncelloCH I don't like the idea of putting in vue just for the popover menu, this adds quite some overhead if we don't just migrate the whole sharing tab to vue.

[violoncelloCH]

@juliushaertl ah, I see... so this could be a reason to switch the whole sharing tab/sidepanel to vue... don't we want to switch to vue and get rid of jquery completely anyway? (this would be one step then as mentioned in #12980)

[jancborchardt]

@violoncelloCH The federation popup is also implemented without Vue.js, so let’s discuss this separately. :) This is tracked in the sidebar standardization at #10289

[ronivaldo]

BTW, @jancborchardt the default option is checked for "Can Edit" checkbox. It would be great if we could have a setting for this in order to change the default behavior of the entire application. I searched for this but I could not find it.

[jancborchardt]

@ronivaldo this is accounted for in the specification in the first post:

Now when you change this current setting, it could be remembered. Either for the session only, per file/folder or simply globally. We can discuss what’s best and most feasible.

And I’d say it should be remembered globally: Much simpler, and then it would be a setting without people needing to change a specific setting, but it just being based on their workflow.

[jospoortvliet]

FWIW I think it is a brilliant solution!

[jancborchardt]

@rullzer @MorrisJobke FYI I tentantively set this to the 17 milestone so it doesn’t get forgotten. :) We wanted to tackle it for a long time, and now there’s a good spec and mockup.

[tobiasKaminsky]

Now when you change this current setting, it could be remembered. Either for the session only, per file/folder or simply globally. We can discuss what’s best and most feasible.

Here I vote for "global". In opposite of grid vs list view decision, I think this is not that much folder based, so having the last set configuration available again is good enough…

[tobiasKaminsky]

As decided on hackweek: always switch to "edit" as default, like it is now