-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP8.1 support #6131
Add PHP8.1 support #6131
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
FYI. Detect encoding is not working as expected any longer, see php/php-src#8279 |
Damn, what can we do about it? Wait for an upstream patch of php? PS: Also relevant php/php-src#8439 |
You can use mb_check_encoding in a loop to get the same behavior as before from mb_detect_encoding. |
def64a8
to
5fc3888
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
it now also fails locally when I run Related https://stackoverflow.com/questions/69793527/gitlab-testing-suddenly-get-error-with-symfony-project |
New plan: disable coverage for PHP8.1 for now. |
5f3df84
to
4b892bf
Compare
55a14ae
to
b2d3c89
Compare
Signed-off-by: Christoph Wurst <[email protected]>
b2d3c89
to
91610d4
Compare
/** | ||
* @return array | ||
*/ | ||
#[ReturnTypeWillChange] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://php.watch/versions/8.1/ReturnTypeWillChange
Oo interesting stuff
Ref nextcloud/groupware#27