Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP8.1 DateTime constructor null time #4

Merged
merged 1 commit into from
May 23, 2022
Merged

Fix PHP8.1 DateTime constructor null time #4

merged 1 commit into from
May 23, 2022

Conversation

ChristophWurst
Copy link

@ChristophWurst ChristophWurst commented May 23, 2022 •
edited
Loading 

2022-05-23T12:36:26.1200227Z PHP Deprecated:  rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 38
2022-05-23T12:36:26.1201392Z PHP Deprecated:  DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 51
2022-05-23T12:36:26.1202223Z PHP Deprecated:  DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 53
2022-05-23T12:36:26.1203093Z PHP Deprecated:  rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 38
2022-05-23T12:36:26.1203872Z PHP Deprecated:  DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 51
2022-05-23T12:36:26.1204664Z PHP Deprecated:  DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 53
2022-05-23T12:36:26.1298918Z PHP Deprecated:  rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 38
2022-05-23T12:36:26.1300087Z PHP Deprecated:  DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 51
2022-05-23T12:36:26.1300898Z PHP Deprecated:  DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 53
2022-05-23T12:36:26.1301658Z PHP Deprecated:  rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 38
2022-05-23T12:36:26.1302506Z PHP Deprecated:  DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 51
2022-05-23T12:36:26.1303382Z PHP Deprecated:  DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/runner/work/Imap_Client/Imap_Client/lib/Horde/Imap/Client/DateTime.php on line 53

Proof that 'now' gives the same result as null: https://3v4l.org/mPXnf

Upstream PR horde#20

@ChristophWurst ChristophWurst mentioned this pull request May 23, 2022
Merged
17 tasks
@bytestream bytestream merged commit 7ebbf0e into bytestream:master May 23, 2022
@ChristophWurst ChristophWurst deleted the fix/php8.1-datetime-null-time branch May 23, 2022 13:43
bytestream pushed a commit that referenced this pull request Sep 15, 2022
@mrubinsk
[mjr] Null string fixes for PHP 8.1 (PR #4, Christoph Wurst <christop…
0e1173f 
…[email protected]>)
st3iny pushed a commit to st3iny/horde-imap-client that referenced this pull request Nov 4, 2024
@bytestream
Test on PHP 8.3 (bytestream#4)
893a805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bytestream bytestream bytestream approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @bytestream