Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdfviewer design #443

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Fix pdfviewer design #443

merged 1 commit into from
Jul 13, 2021

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Jul 8, 2021

Fix #279
Fix #238

Desktop

Before After After with sidebar open
image image image

Mobile

Before Before After
image image image

Signed-off-by: szaimen [email protected]

@szaimen

This comment has been minimized.

@szaimen

This comment has been minimized.

@szaimen

This comment has been minimized.

@szaimen

This comment has been minimized.

@szaimen szaimen requested a review from beardhatcode July 9, 2021 10:47
@szaimen

This comment has been minimized.

@szaimen

This comment has been minimized.

@szaimen szaimen requested a review from artonge July 13, 2021 09:46
Signed-off-by: szaimen <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the enh/noid/fix-design branch from b95e256 to e17b570 Compare July 13, 2021 12:21
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@szaimen
Copy link
Collaborator Author

szaimen commented Jul 13, 2021

Thanks @artonge for compiling and pushing the js! :)

@szaimen szaimen merged commit 6cc0da0 into master Jul 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/fix-design branch July 13, 2021 12:29
@szaimen
Copy link
Collaborator Author

szaimen commented Jul 13, 2021

/backport to stable22

@szaimen
Copy link
Collaborator Author

szaimen commented Jul 13, 2021

/backport to stable21

@szaimen
Copy link
Collaborator Author

szaimen commented Jul 13, 2021

/backport to stable20

@jancborchardt
Copy link
Member

Yeeessss full width and to the bottom! :D Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants