No way to close the pdf viewer on mobile/in portrait mode

[szaimen]

Steps to reproduce

1. install NC20
2. open a pdf file with the pdf viewer on mobile or laptop/pc in portrait mode
3. wait a few seconds until the viewer buttons disappear (that lay ontop of the pdf viewer for a short time)
4. see screenshots

Expected behaviour

should be able to close the pdf viewer

Actual behaviour

cannot close the pdf viewer

Screenshots

[skjnldsv]

We need to add a way for viewer types to register if they want the clear-view feature enabled or not.

[oogie]

+1: I also have this problem, would be awesome if fixed!

Effected devices / browsers

Encountered this unwanted behaviour on Android 11 (Chrome 87.0 & FF 84.1), IOS 14.3 (Safari) and Windows 10 with small browser window sizes (FF 84.0 & Chrome 87.0). I run Nextcloud version 20.0.4 and PDF viewer 2.0.1 (according to the Nextcloud Apps overview)

Possible correct behaviour

Some sort of close button would obviously be nice. In addition: closing the whole PDF modal when the browser's back button is pressed (via window.onpopstate) would, in my opinion, be very intuitive.

[komdrive]

+1, and I also see this problem, really looking forward to the fix.
Android 11, Chrome 89, Nextcloud 20.0.8.1 (PDF Viewer 2.0.1)

I get out of the situation: press "refresh page" and press "cancel" or press "back" and "refresh"

[elpraga]

I am also experiencing this issue. Would it be possible to get the Close menu option back?

I am aware that it was deliberately eliminated from the menu, but in my opinion, it would be better to have two options in all cases to close the viewer rather than none in some cases.

[elpraga]

Displaying linear (web optimised) PDFs can be enabled on Chrome using this extension https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm (which in turn uses pdf.js)

[szaimen]

@skjnldsv is this something that must get fixed in the viewer repository or here? Do you have some pointers?

[skjnldsv]

We need to add an option in the way apps register viewer rendering modules to disable the fade-out of the menus. So should be in viewer AND then here.

[skjnldsv]

https://github.com/nextcloud/viewer/blob/b3eb0913bff415f3ca30661b997ba27fa3ea6373/src/views/Viewer.vue#L29
https://github.com/nextcloud/viewer/blob/b3eb0913bff415f3ca30661b997ba27fa3ea6373/src/services/Viewer.js#L68

Add an options in models: https://github.com/nextcloud/viewer/blob/b3eb0913bff415f3ca30661b997ba27fa3ea6373/src/models/videos.js#L25-L41
Then

files_pdfviewer/src/main.js

Lines 26 to 35 in 92eec1d

	OCA.Viewer.registerHandler({
	id: 'pdf',
	mimes: [
	'application/pdf',
	'application/illustrator',
	],
	component: PDFView,
	})

And use the handler options.disableClearView if any 🤔

[elpraga]

When can this change be expected to land in the updates?

[szaimen]

In the next minor updates

[elpraga]

Thank you for your swift answer!

[CircuitC]

The issue is closed but I still have this issue in the iOS app and in Safari mobile, would it be best to upload screenshots here?

[szaimen]

It will be fixed with the next releases