Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block upgrade before changes when the upgrade is forbidden #1809

Closed
vdanjean opened this issue Aug 26, 2022 · 1 comment · Fixed by #2018
Closed

Block upgrade before changes when the upgrade is forbidden #1809

vdanjean opened this issue Aug 26, 2022 · 1 comment · Fixed by #2018

Comments

@vdanjean
Copy link

Hi,

I'm not sure if this is a nextcloud docker image bug or a nextcloud server one.
I'm using official nextcloud docker images through a docker-compose file that was referencing the 'nextcloud' docker image.

Due to various reasons, I was running nextcloud 22, and I missed nextcloud 23.
Today, I ran

docker-compose build --pull
docker-compose up -d

And it have been a really big mess: skipping a major upgrade is not allowed by nexcloud, but trying to change the image back to the nextcloud 23 (using 'nextcloud:23-apache') did not work either, because some files have been modified and were referencing the 24 version ('no downgrade allowed' whereas the 22->24 migration has not been done).

With the help of internet, I found:

So, I'm not sure if the problem comes from the update of the docker image with docker compose, or if the problem comes from nextcloud server. But it would be very appreciated if the version check were done before any changes are done. Or if getting the 23 image really install the 23 version (it was not the case for version.php and the apps/* at least, I'm not a docker specialist so I do not know why).

That said, I removed the reference to the nextcloud:apache and I'm using nextcloud:MAJOR-apache now, to avoid to suffer this upgrade problem again. Major version upgrade will need that I manually enable it in my docker-compose.yml file. I think that it could be useful to add this (avoid images without major version) in the documentation if early blocking the upgrade is not possible/easy.

Regards
Vincent

wetneb added a commit to wetneb/nextcloud-docker that referenced this issue Jun 24, 2023
…ifferent

Closes nextcloud#1809. This prevents the install from getting in a state where none
of the Docker images will accept running given the contents of the volumes.
wetneb added a commit to wetneb/nextcloud-docker that referenced this issue Jun 24, 2023
Closes nextcloud#1809. This prevents the install from getting in a state where none
of the Docker images will accept running given the contents of the volumes.

Signed-off-by: Antonin Delpeuch <[email protected]>
@wetneb
Copy link
Contributor

wetneb commented Jun 24, 2023

I agree that this is quite frustrating UX - I ended up in the state described above, not being able to run NextCloud from any image, and not knowing what to change in the volumes for any version to accept tot boot. Quite stressful experience.

So I have proposed a change to check for this before running any step of the update path: #2018.

@J0WI J0WI closed this as completed in #2018 Jul 9, 2023
J0WI added a commit that referenced this issue Jul 9, 2023
…ifferent (#2018)

* Block upgrade if it is not supported

Closes #1809. This prevents the install from getting in a state where none
of the Docker images will accept running given the contents of the volumes.

Signed-off-by: Antonin Delpeuch <[email protected]>

* Update docker-entrypoint.sh

Co-authored-by: J0WI <[email protected]>
Signed-off-by: Antonin Delpeuch <[email protected]>

* Update docker-entrypoint.sh

Co-authored-by: J0WI <[email protected]>
Signed-off-by: Antonin Delpeuch <[email protected]>

* Remove extra function

Signed-off-by: Antonin Delpeuch <[email protected]>

* Update docker-entrypoint.sh

Co-authored-by: J0WI <[email protected]>
Signed-off-by: Antonin Delpeuch <[email protected]>

---------

Signed-off-by: Antonin Delpeuch <[email protected]>
Co-authored-by: J0WI <[email protected]>
ananace pushed a commit to ananace/docker-nextcloud that referenced this issue May 10, 2024
…ifferent (nextcloud#2018)

* Block upgrade if it is not supported

Closes nextcloud#1809. This prevents the install from getting in a state where none
of the Docker images will accept running given the contents of the volumes.

Signed-off-by: Antonin Delpeuch <[email protected]>

* Update docker-entrypoint.sh

Co-authored-by: J0WI <[email protected]>
Signed-off-by: Antonin Delpeuch <[email protected]>

* Update docker-entrypoint.sh

Co-authored-by: J0WI <[email protected]>
Signed-off-by: Antonin Delpeuch <[email protected]>

* Remove extra function

Signed-off-by: Antonin Delpeuch <[email protected]>

* Update docker-entrypoint.sh

Co-authored-by: J0WI <[email protected]>
Signed-off-by: Antonin Delpeuch <[email protected]>

---------

Signed-off-by: Antonin Delpeuch <[email protected]>
Co-authored-by: J0WI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants