-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix native UI #7101
Fix native UI #7101
Conversation
412ae09
to
b1cbb41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outcome of call with @camilasan
Now
- Alignment of search text
- Native height and border radius
-
Header color goes away
-
Adjust status icon background
-
Icon of more apps https://fonts.google.com/icons?selected=Material+Symbols+Outlined:apps:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=apps&icon.size=24&icon.color=%235f6368
-
Dropdown menus border-radius like native ones
-
Wider account selection dropdown 150%
-
Folder menu: border should be as the apps dropdown and no separation lines between elements
Possibly follow up
- Drop-down: same margin on all of them so that they dont "touch" the boundaries of the container element
- "..." menus need to have some right margin so that they don't touch the boundaries of parent
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small comment
/backport to stable-3.14 |
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…er menus. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…ropdown menus uses half. Signed-off-by: Camila Ayres <[email protected]>
…ackground color. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
e266024
to
72e5ff4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 very small comments
Signed-off-by: Camila Ayres <[email protected]>
cacc0f1
to
6cde9c8
Compare
AppImage file: nextcloud-PR-7101-6cde9c8cc8008a38b0fb4a239f473fef1559fcac-x86_64.AppImage |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Continues #7077.
............................................................
............................................................
mac OS
Dark mode:
Light mode: