Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.14] Native buttons #7077

Merged
merged 41 commits into from
Sep 6, 2024
Merged

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 6, 2024

Backport of #6980

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested a review from camilasan September 6, 2024 08:49
@backportbot backportbot bot added this to the 3.14.0 milestone Sep 6, 2024
camilasan and others added 26 commits September 6, 2024 10:55
should get us native colors as much as possible

Signed-off-by: Matthieu Gallien <[email protected]>
will fix white corners appearing below the main dialog content

Signed-off-by: Matthieu Gallien <[email protected]>
remove custom binding between c++ native Qt API for system palette and
our QML styling code for colors detection

fixes many issues with dark mode using Windows native style

Signed-off-by: Matthieu Gallien <[email protected]>
…CButtonContents components.

Signed-off-by: Camila Ayres <[email protected]>
… control (property: "background").

Signed-off-by: Camila Ayres <[email protected]>
… control (property: "contentItem").

Signed-off-by: Camila Ayres <[email protected]>
… control (property: "background").

Signed-off-by: Camila Ayres <[email protected]>
… control (property: "contextItem").

Signed-off-by: Camila Ayres <[email protected]>
… control (property: "indicator").

Signed-off-by: Camila Ayres <[email protected]>
… control (property: "background").

Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
@mgallien mgallien force-pushed the backport/6980/stable-3.14 branch from e513037 to 4694aae Compare September 6, 2024 08:57
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7077-4694aae25b86413a044c25a7059b1fbaf63c7f38-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit bd3e5df into stable-3.14 Sep 6, 2024
11 of 14 checks passed
@mgallien mgallien deleted the backport/6980/stable-3.14 branch September 6, 2024 09:03
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)
3 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@camilasan camilasan mentioned this pull request Sep 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants