Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper online status for user ('dnd', 'online', 'invisible', etc.) to enable or disable desktop notifications. #4507

Merged
merged 1 commit into from
May 16, 2022

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented May 9, 2022

Signed-off-by: alex-z [email protected]

@allexzander allexzander changed the title Use proper online status for user ('dnd', 'online', 'invisible', etc.… Use proper online status for user ('dnd', 'online', 'invisible', etc.) to enable or disable desktop notifications. May 10, 2022
@allexzander allexzander marked this pull request as ready for review May 10, 2022 16:14
src/libsync/account.h Outdated Show resolved Hide resolved
src/gui/accountstate.h Outdated Show resolved Hide resolved
@allexzander allexzander force-pushed the bugfix/desktop-notifications-get-displayed branch 3 times, most recently from acd5e89 to c7b63a0 Compare May 13, 2022 15:25
@allexzander allexzander requested a review from mgallien May 13, 2022 15:50
…) to enable or disable desktop notifications.

Signed-off-by: alex-z <[email protected]>
@allexzander allexzander force-pushed the bugfix/desktop-notifications-get-displayed branch from 106f256 to 514f72f Compare May 16, 2022 07:47
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4507-514f72f9754ed2c65f4f180f979af57ec82589c4-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

22.2% 22.2% Coverage
0.0% 0.0% Duplication

@allexzander allexzander merged commit 85d8128 into master May 16, 2022
@allexzander allexzander deleted the bugfix/desktop-notifications-get-displayed branch May 16, 2022 08:40
@allexzander
Copy link
Contributor Author

/backport to stable-3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants