Skip to content

Commit

Permalink
Fix review comments.
Browse files Browse the repository at this point in the history
Signed-off-by: alex-z <[email protected]>
  • Loading branch information
allexzander committed May 13, 2022
1 parent c7b63a0 commit acd5e89
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions src/gui/accountstate.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ AccountState::AccountState(AccountPtr account)
this, &AccountState::slotCredentialsAsked);
connect(account.data(), &Account::pushNotificationsReady,
this, &AccountState::slotPushNotificationsReady);
connect(account.data(), &Account::userOnlineStatusChanged, this,
&AccountState::slotUserOnlineStatusChanged);
connect(account.data(), &Account::userStatusChanged, this,
&AccountState::slotServerUserStatusChanged);

connect(this, &AccountState::isConnectedChanged, [=]{
// Get the Apps available on the server if we're now connected.
Expand Down Expand Up @@ -561,7 +561,7 @@ void AccountState::slotPushNotificationsReady()
}
}

void AccountState::slotUserOnlineStatusChanged()
void AccountState::slotServerUserStatusChanged()
{
setDesktopNotificationsAllowed(_account->userStatusConnector()->userStatus().state() != UserStatus::OnlineStatus::DoNotDisturb);
}
Expand Down
2 changes: 1 addition & 1 deletion src/gui/accountstate.h
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ private Q_SLOTS:

void slotCheckConnection();
void slotPushNotificationsReady();
void slotUserOnlineStatusChanged();
void slotServerUserStatusChanged();

private:
AccountPtr _account;
Expand Down
2 changes: 1 addition & 1 deletion src/libsync/account.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ void Account::setupUserStatusConnector()
connect(_userStatusConnector.get(), &UserStatusConnector::userStatusFetched, this, [this](const UserStatus &) {
emit userStatusChanged();
});
connect(_userStatusConnector.get(), &UserStatusConnector::userOnlineStatusChanged, this, &Account::userOnlineStatusChanged);
connect(_userStatusConnector.get(), &UserStatusConnector::userStatusChanged, this, &Account::userStatusChanged);
connect(_userStatusConnector.get(), &UserStatusConnector::messageCleared, this, [this] {
emit userStatusChanged();
});
Expand Down
2 changes: 1 addition & 1 deletion src/libsync/account.h
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ public slots:

void userStatusChanged();

void userOnlineStatusChanged();
void userStatusChanged();

void capabilitiesChanged();

Expand Down
4 changes: 2 additions & 2 deletions src/libsync/ocsuserstatusconnector.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ void OcsUserStatusConnector::onUserStatusFetched(const QJsonDocument &json, int
emit userStatusFetched(_userStatus);

if (oldOnlineState != _userStatus.state()) {
emit userOnlineStatusChanged();
emit userStatusChanged();
}
}

Expand Down Expand Up @@ -423,7 +423,7 @@ void OcsUserStatusConnector::onUserStatusOnlineStatusSet(const QJsonDocument &js
emit userStatusSet();

if (oldOnlineState != _userStatus.state()) {
emit userOnlineStatusChanged();
emit userStatusChanged();
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/libsync/userstatusconnector.h
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class OWNCLOUDSYNC_EXPORT UserStatusConnector : public QObject
void userStatusFetched(const UserStatus &userStatus);
void predefinedStatusesFetched(const std::vector<UserStatus> &statuses);
void userStatusSet();
void userOnlineStatusChanged();
void userStatusChanged();
void messageCleared();
void error(Error error);
};
Expand Down

0 comments on commit acd5e89

Please sign in to comment.