fix(activity): Fix permission checks when rendering activities in bac… #5533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kground jobs Signed-off-by: Joas Schilling <[email protected]>
juliusknorr
approved these changes
Feb 2, 2024
delete-merged-branch
bot
deleted the
bugfix/noid/fix-permission-check-in-background-job
branch
|
/backport to stable28 |
|
/backport to stable27 |
|
/backport to stable26 |
This was referenced Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kground jobs
{ "reqId": "AwQLI2pqTBuljW0TBR8z", "level": 3, "time": "2024-01-29T08:01:05+00:00", "remoteAddr": "", "user": "--", "app": "core", "method": "", "url": "--", "message": "Error while running background job (class: OCA\\Activity\\BackgroundJob\\EmailNotification, arguments: )", "userAgent": "--", "version": "28.0.2.3", "exception": { "Exception": "TypeError", "Message": "OC\\Group\\Manager::getUserIdGroupIds(): Argument #1 ($uid) must be of type string, null given, called in …/lib/private/Group/Manager.php on line 374", "Code": 0, "Trace": [ { "file": "…/lib/private/Group/Manager.php", "line": 374, "function": "getUserIdGroupIds", "class": "OC\\Group\\Manager", "type": "->", "args": [ null ] }, { "file": "…/apps/deck/lib/Service/PermissionService.php", "line": 234, "function": "isInGroup", "class": "OC\\Group\\Manager", "type": "->", "args": [ null, "M…g" ] }, { "file": "…/apps/deck/lib/Service/PermissionService.php", "line": 115, "function": "userCan", "class": "OCA\\Deck\\Service\\PermissionService", "type": "->", "args": [ [ [ "OCA\\Deck\\Db\\Acl", 51 ], [ "OCA\\Deck\\Db\\Acl", 54 ], [ "OCA\\Deck\\Db\\Acl", 55 ], [ "OCA\\Deck\\Db\\Acl", 93 ], [ "OCA\\Deck\\Db\\Acl", 290 ] ], 0, null ] }, { "file": "…/apps/deck/lib/Service/PermissionService.php", "line": 160, "function": "getPermissions", "class": "OCA\\Deck\\Service\\PermissionService", "type": "->", "args": [ 250, null ] }, { "file": "…/apps/deck/lib/Activity/ActivityManager.php", "line": 571, "function": "checkPermission", "class": "OCA\\Deck\\Service\\PermissionService", "type": "->", "args": [ [ "OCA\\Deck\\Db\\CardMapper" ], 7871, 0 ] }, { "file": "…/apps/deck/lib/Activity/DeckProvider.php", "line": 131, "function": "canSeeCardActivity", "class": "OCA\\Deck\\Activity\\ActivityManager", "type": "->", "args": [ 7871 ] }, { "file": "…/apps/activity/lib/MailQueueHandler.php", "line": 436, "function": "parse", "class": "OCA\\Deck\\Activity\\DeckProvider", "type": "->", "args": [ "en", [ "OC\\Activity\\Event" ] ] }, { "file": "…/apps/activity/lib/MailQueueHandler.php", "line": 333, "function": "parseEvent", "class": "OCA\\Activity\\MailQueueHandler", "type": "->", "args": [ "en", [ "OC\\Activity\\Event" ] ] }, { "file": "…/apps/activity/lib/MailQueueHandler.php", "line": 130, "function": "sendEmailToUser", "class": "OCA\\Activity\\MailQueueHandler", "type": "->", "args": [ "m…a", "m…m", "en", "Europe/Tirane", 1706515264 ] }, { "file": "…/apps/activity/lib/BackgroundJob/EmailNotification.php", "line": 60, "function": "sendEmails", "class": "OCA\\Activity\\MailQueueHandler", "type": "->", "args": [ 500, 1706515264 ] }, { "file": "…/lib/private/BackgroundJob/Job.php", "line": 54, "function": "run", "class": "OCA\\Activity\\BackgroundJob\\EmailNotification", "type": "->", "args": [ null ] }, { "file": "…/lib/private/BackgroundJob/TimedJob.php", "line": 60, "function": "execute", "class": "OC\\BackgroundJob\\Job", "type": "->", "args": [ [ "OC\\BackgroundJob\\JobList" ], [ "OC\\Log" ] ] }, { "file": "…/cron.php", "line": 152, "function": "execute", "class": "OC\\BackgroundJob\\TimedJob", "type": "->", "args": [ [ "OC\\BackgroundJob\\JobList" ], [ "OC\\Log" ] ] } ], "File": "…/lib/private/Group/Manager.php", "Line": 391, "message": "Error while running background job (class: OCA\\Activity\\BackgroundJob\\EmailNotification, arguments: )", "CustomMessage": "Error while running background job (class: OCA\\Activity\\BackgroundJob\\EmailNotification, arguments: )" } }Summary
TODO
Checklist