-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MailQueueHandler: Catch provider errors #1545
Conversation
Signed-off-by: Marcel Klehr <[email protected]>
1 flaky test on run #1226 ↗︎
Details:
cypress/e2e/sidebar.cy.ts • 1 flaky test • Run E2E
Review all test suite changes for PR #1545 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least without logging this is a very bad idea. It makes it impossible to find future errors by any app in their activity handling.
Signed-off-by: Marcel Klehr <[email protected]>
/backport to stable28 |
/backport-skjnldsv to stable28 |
/backport to stable28 |
/backport to stable27 |
It seems like part of the activity API is to allow providers to throw \InvalidArgumentExceptions when they don't recognize an event, which are now flooding the logs, because they are part of \Throwable. |
opened a PR: #1586 |
No description provided.