Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailQueueHandler: Catch provider errors #1545

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

marcelklehr
Copy link
Member

No description provided.

@marcelklehr marcelklehr requested a review from artonge February 2, 2024 10:41
Copy link

cypress bot commented Feb 2, 2024

1 flaky test on run #1226 ↗︎

0 10 0 0 Flakiness 1

Details:

MailQueueHandler: Catch provider errors
Project: Activity Commit: 401b600f31
Status: Passed Duration: 02:43 💡
Started: Feb 5, 2024 7:14 PM Ended: Feb 5, 2024 7:17 PM
Flakiness  cypress/e2e/sidebar.cy.ts • 1 flaky test • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has rename activity Test Replay Screenshots

Review all test suite changes for PR #1545 ↗︎

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least without logging this is a very bad idea. It makes it impossible to find future errors by any app in their activity handling.

@marcelklehr marcelklehr merged commit 3877e17 into master Feb 8, 2024
43 checks passed
@marcelklehr marcelklehr deleted the fix/catch-provider-errors branch February 8, 2024 09:49
@marcelklehr
Copy link
Member Author

/backport to stable28

@marcelklehr
Copy link
Member Author

/backport-skjnldsv to stable28

@nickvergessen
Copy link
Member

/backport to stable28

@marcelklehr
Copy link
Member Author

/backport to stable27

@marcelklehr
Copy link
Member Author

It seems like part of the activity API is to allow providers to throw \InvalidArgumentExceptions when they don't recognize an event, which are now flooding the logs, because they are part of \Throwable.

@marcelklehr
Copy link
Member Author

opened a PR: #1586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants