-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Breadcrumbs component #1105
Remove Breadcrumbs component #1105
Conversation
Hey, @MarcelRobitaille. I just tried with the result a bit. It is working great and incredibly. There is no glitch and I have the impression of a very clean UI. I just found one thing: If the display gets narrow enough, the left menu slides away. However, there is no longer a button to enlarge the side menu (see image): |
Hi @christianlupus. I am glad you like it. I noticed that button was missing as well. It's missing in master though (screenshot below is with master checked out). There is a space for the button, but no button. I thought it was unrelated to this. Do you know why this would be? Knowing how it was taken out / how it was implemented before would help me add it back here. |
It is a standard component. See the docs at https://nextcloud-vue-components.netlify.app/#/Components/App%20containers?id=appnavigation. |
3c5df9a
to
f8b73b7
Compare
I found the problem. The old button was actually still there, but underneath the main content. I made my window narrow and did |
Signed-off-by: Marcel Robitaille <[email protected]> Signed-off-by: Christian Wolf <[email protected]>
- Remove home button - Consistently show the "mode" (editing recipe, viewing recipe, viewing category) - Always show the "location" (recipe name, "All recipes", category name) Signed-off-by: Marcel Robitaille <[email protected]> Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Marcel Robitaille <[email protected]> Signed-off-by: Christian Wolf <[email protected]>
Makes the root template more concise and explicit and makes sure you get the class name right Signed-off-by: Marcel Robitaille <[email protected]>
Signed-off-by: Marcel Robitaille <[email protected]>
Signed-off-by: Marcel Robitaille <[email protected]>
Signed-off-by: Marcel Robitaille <[email protected]>
Signed-off-by: Marcel Robitaille <[email protected]>
1bedac8
to
2d547ad
Compare
Signed-off-by: Marcel Robitaille <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not worked my way through every single line but this seems working pretty well
Breadcrumbs
component.h2
. Consistently show the "mode" where applicable (Viewing category, Viewing recipe, Editing recipe). Previously, "Edit" was shown when editing, but nothing was shown when viewing. This should be more clear and consistent.To-do:
Fixes #281
Fixes #896
Peek.2022-07-23.16-57.mp4