Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit recipes when the title is too long for the viewport width #291

Closed
siccovansas opened this issue Aug 3, 2020 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@siccovansas
Copy link

Description
When your recipe title is longer than your viewport width, it is hidden behind '...'. When you click on it you see a weird structure of 3 folders + the recipe title. The biggest problem though is that you also can't edit the recipe.

Reproduction
Steps to reproduce the behavior:

  1. Make a recipe with a long title
  2. Make your viewport smaller (e.g. CTRL + SHIFT + M on Firefox, or simply resize your window or view on a mobile phone)
  3. See problem

Expected behavior
You should always be able to edit a recipe, even if it has a long name

Screenshots
issue

Browser

  • Firefox 79
  • Firefox for Android
@siccovansas siccovansas added the bug Something isn't working label Aug 3, 2020
@sam-19
Copy link
Contributor

sam-19 commented Aug 15, 2020

I have looked into this and cannot find a way to fix it; I fear it's a bug in the Nextcloud Vue component or maybe it was not meant to be used the way I use it. However, displaying the recipe name on the breadcrumb row may not be such a good idea anyways, because even on full viewport width, it is often clipped. Changing the recipe name to just "Recipe" would solve this issue. What do you think, @mrzapp?
Edit: I just realized that there is a real possibility that the word "recipes" can be so long in some languages, that this problem would occur constantly. It is of course possible to impose some kind of check, like cut strings over a certain number of characters, but it may not look pretty...

@seyfeb
Copy link
Collaborator

seyfeb commented Aug 26, 2020

Edit: I just realized that there is a real possibility that the word "recipes" can be so long in some languages, that this problem would occur constantly.

I don’t exactly know but quick googling some examples the single word (in english) does not seem to be incredibly long in different languages. The longest on the list is “paraan ng pagluluto” (Filipino) which might be okay (?). Anyway, this would have to be tested.

@christianlupus
Copy link
Collaborator

Closed in #1105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants