Migrate to Text editor API #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 failed and 1 flaky tests on run #1255 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Page list > Page trash > allows to trash and restore page with subpage and attachment |
Screenshots
|
|
cypress/e2e/page-list.spec.js • 1 failed test • Nextcloud master
| Test | Artifacts | |
|---|---|---|
| Page list > Page trash > allows to trash and restore page with subpage and attachment |
Screenshots
|
|
cypress/e2e/page-details.spec.js • 1 flaky test • Nextcloud stable27
| Test | Artifacts | |
|---|---|---|
| Page details > Display table of contents > Allows to display/close TOC and switch page modes in between |
Screenshots
|
|
Review all test suite changes for PR #936 ↗︎
mejo-
force-pushed
the
enh/editor-api
branch
3 times, most recently
from
c99814f to
d206911
Compare
mejo-
force-pushed
the
enh/editor-api
branch
7 times, most recently
from
765f4c2 to
7736a35
Compare
mejo-
force-pushed
the
enh/editor-api
branch
11 times, most recently
from
b011603 to
004f480
Compare
Incorporate changes from #929 into new component. Signed-off-by: Jonas <[email protected]>
This allows us to publish a Collectives release that uses the editor API while people still run Nextcloud server releases that don't have the latest editor API improvements that we require. If the version is unset or below '1.0', we'll simply not use the editor API. Signed-off-by: Jonas <[email protected]>
This code doesn work anymore and it's not needed anymore either. Signed-off-by: Jonas <[email protected]>
Required for attachments to work in reader. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Also fix some further issues with version view along the way: * Show emoji and fix alignment of page title in version view * Mark selected version as active in sidebar version list Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
* Wait minimum 3 seconds for images to be loaded. * Don't open the print dialog a second time when opening it after the timeout. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Fixes: #952 Signed-off-by: Jonas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Use the new editor API from Text app if available.
Additionally this PR includes smaller additional fixes and refactoring (printing related, cypress tests, outline related)
Requirements:
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)