Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a clean way to reuse code from text app #18

Closed
mejo- opened this issue May 18, 2020 · 9 comments · Fixed by #936
Closed

Find a clean way to reuse code from text app #18

mejo- opened this issue May 18, 2020 · 9 comments · Fixed by #936

Comments

@mejo-
Copy link
Member

mejo- commented May 18, 2020

In GitLab by @azul on May 18, 2020, 15:59

  • find a cleaner solution than importing the CSS from text app with relative links (@import './../../apps/text/css/prosemirror';)
  • avoid copying all the css
  • allow for defining our own Component that uses EditorWrapper.
  • maybe use https://github.com/juliushaertl/nextcloud-text

Missing from !17

@mejo-
Copy link
Member Author

mejo- commented Aug 4, 2020

According to Julius, the nextcloud-text library is already usable to some degree. It's not released yet, but could already be used with npm link to local directory.

https://nextcloud-text.netlify.app/markdown.html

@mejo-
Copy link
Member Author

mejo- commented Aug 23, 2020

marked this issue as related to #39

@mejo-
Copy link
Member Author

mejo- commented Aug 23, 2020

marked this issue as related to #83

@mejo-
Copy link
Member Author

mejo- commented Aug 23, 2020

marked this issue as related to #93

@mejo-
Copy link
Member Author

mejo- commented May 10, 2021

In GitLab by @azul on May 10, 2021, 08:23

removed the relation with #93

@mejo-
Copy link
Member Author

mejo- commented May 4, 2022

We've made a huge step forward here: starting with release 1.1.0, we use the new @nextcloud/text NPM package for the view mode. 🚀

@mejo-
Copy link
Member Author

mejo- commented Sep 28, 2022

Our plan is to expose an editor component as a global object in Text (similar to OC) and use that object in Collectives. Switching between view and edit mode will happen completely in Text.

Short-term, we'll copy the logic that's currently implemented in Collectives into the new exposed Text component: loading RichTextReader with the page content from webdav in the front (for fast loading experience) and loading the full-fledged Editor with page content from syncService in the back.

Mid-term, we might improve the performance in Text and get rid of having two seperate components (RichTextReader and Editor) there.

@juliusknorr
Copy link
Member

nextcloud/text#3615 would be the upstream pull request for exposing text through an API

@juliusknorr juliusknorr moved this to 📄 To do (~10 entries) in 📝 Office team Feb 22, 2023
@mejo- mejo- added the roadmap label Mar 24, 2023
@juliusknorr juliusknorr moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Sep 6, 2023
@mejo-
Copy link
Member Author

mejo- commented Sep 7, 2023

Some stuff to cleanup when removing the current legacy Text integration (after migrating to the new editor API):

  • Listeners for collectives:text-image-node:* can be removed, they're replaced by text:image-node.* events.

@mejo- mejo- mentioned this issue Oct 10, 2023
7 tasks
@mejo- mejo- closed this as completed in #936 Nov 8, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants